Re: [PATCH 2/7] iomap: implement ioread64 and iowrite64

From	Logan Gunthorpe <logang@deltatee.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/7] iomap: implement ioread64 and iowrite64
Date	2017-06-26 23:30 +0200
Message-ID	<tWJK1-7Am-1@gated-at.bofh.it> (permalink)
References	<tVdsS-7hT-17@gated-at.bofh.it> <tVdCy-7lD-19@gated-at.bofh.it> <tWJ7j-75V-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 6/26/2017 2:43 PM, Arnd Bergmann wrote:
> This hardcodes the behavior of include/linux/io-64-nonatomic-hi-lo.h, which
> I find rather confusing, as only about one in five drivers wants this
> behavior.
>
> I'd suggest you don't add it in lib/iomap.c at all for 32-bit architectures,
> but rather use the same logic that we have for readq/writeq in
> io-64-nonatomic-hi-lo.h and io-64-nonatomic-lo-hi.h, adding
> {lo_hi,hi_lo}_{ioread,iowrite}{,be} to the same files, and provide
> the {ioread,iowrite}{,be} macros only if they have not been defined
> at that point.

Thanks Arnd. Yes, I'm already reworking this patchset to do exactly that.

Logan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/7] iomap: implement ioread64 and iowrite64 Logan Gunthorpe <logang@deltatee.com> - 2017-06-22 19:00 +0200
  Re: [PATCH 2/7] iomap: implement ioread64 and iowrite64 Arnd Bergmann <arnd@arndb.de> - 2017-06-26 22:50 +0200
    Re: [PATCH 2/7] iomap: implement ioread64 and iowrite64 Logan Gunthorpe <logang@deltatee.com> - 2017-06-26 23:30 +0200

csiph-web