Re: [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver

From	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver
Date	2017-06-26 23:20 +0200
Message-ID	<tWJAl-7wF-13@gated-at.bofh.it> (permalink)
References	<tValj-5i5-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, 2017-06-22 at 15:23 +0200, Michael Moese wrote:
> From: Andreas Werner <andreas.werner@men.de>
> 
> Signed-off-by: Andreas Werner <andreas.werner@men.de>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 4 ++++
>  1 file changed, 4 insertions(+)

NACK

Why?  Your lack of patch description does not provide a reasoning on why we
need this change.  I need a patch description that provides justification
on why we need this change, before I add this to my queue for testing and
acceptance upstream.

Please resubmit with the requested information/change.

> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
> b/drivers/net/ethernet/intel/igb/igb_main.c
> index 1cf74aa4ebd9..87e496eeefb1 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -7716,6 +7716,10 @@ static int igb_mii_ioctl(struct net_device
> *netdev, struct ifreq *ifr, int cmd)
>  			return -EIO;
>  		break;
>  	case SIOCSMIIREG:
> +		if (igb_write_phy_reg(&adapter->hw, data->reg_num &
> 0x1F,
> +				      data->val_in))
> +			return -EIO;
> +		break;
>  	default:
>  		return -EOPNOTSUPP;
>  	}

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver Michael Moese <michael.moese@men.de> - 2017-06-22 15:30 +0200
  Re: [PATCH] Added SIOCSMIIREG (mii write) support to intel igb  driver Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2017-06-26 23:20 +0200

csiph-web