Re: [PATCH v2] pinctrl: generic: Add output-enable property

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] pinctrl: generic: Add output-enable property
Date	Mon, 26 Jun 2017 20:50:02 +0200
Message-ID	<tWHfc-5UG-25@gated-at.bofh.it> (permalink)
References	<tV7dM-3dT-29@gated-at.bofh.it>
X-Original-To	Jacopo Mondi <jacopo+renesas@jmondi.org>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EnK7H1/I6qFNYlEl4moyX6p8v8Q8Fv1fO0/wA1EFQzc=; b=jpCLKdOJv2T6UEV87puo9R5TEfISAsr5Gjv2Kv5uBhVxGEHQQOWQQIfnfzaNA9BUGP BP1Cpgb7URyiKg9mNNQ7L7cYR2GP7ljf+LxdQC29I85BlC5jOuJFrJ6iOZAIlN+tHwFa ApOZCIeIfF6cHfbx5kIbJGoRRKkAlEsKg5aUDO5B4hgtbvwLshCyDFX2B+edds5xGUWq JGEGnAmIYmK/HqvqOv6ZvvHHlI6KKIBdk4rUZvpWND+/8ypzh9Pk84GHENqOT97QqV75 MfSjzKn4lqbAeaaWndLDWZmLQ2urils7/6OI/v7DuHmpz8udTnCE9XL8ucIHfKWWThOC WtKQ==
X-Gm-Message-State	AKS2vOxr1P//j8jyx/f01dd6uDWxc1fFk3cs2QArn8CnvvLQKZG+D/Jv YzJkV3gOj+JZ/Q==
X-Received	by 10.36.25.8 with SMTP id b8mr1403794itb.29.1498502451934; Mon, 26 Jun 2017 11:40:51 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	linus.walleij@linaro.org, andy.shevchenko@gmail.com, dongas86@gmail.com, geert+renesas@glider.be, Chris.Brandt@renesas.com, laurent.pinchart@ideasonboard.com, mark.rutland@arm.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 26 Jun 2017 13:40:50 -0500
X-Original-Message-ID	<20170626184050.k4fibk5m42f47sug@rob-hp-laptop>
X-Original-References	<1498125658-14554-1-git-send-email-jacopo+renesas@jmondi.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1675006

Show key headers only | View raw

On Thu, Jun 22, 2017 at 12:00:58PM +0200, Jacopo Mondi wrote:
> Add output-enable generic pin configuration property.
> This properties allows enabling/disabling pin's output capabilities
> without actually driving any value on the line.
> 
> ---
> v1->v2:
>  - Expand the property description as suggested by Laurent. I ended up
>    mentioning the in-famous output buffer :)
> 
> One (more) question to GPIO people on:
> +	PCONFDUMP(PIN_CONFIG_OUTPUT_ENABLE, "output enabled", NULL, false),
> 
> I copied this from INPUT_ENABLE where arguments 2 and 3 passed to PCONFDUMP are
> NULL and false even if the property has an argument, used to enable/disable
> the input mode. Is this intended? Should that be turned instead to
> -	PCONFDUMP(PIN_CONFIG_INPUT_ENABLE, "input enabled", NULL, false),
> +	PCONFDUMP(PIN_CONFIG_INPUT_ENABLE, "input enabled", "enabled", true),
> 
> Note that the same applies to most of the properties that have an
> "enable"/"disable" argument. Just to make sure this is done on purpose.
> 
> Thanks
>    j
>  .../devicetree/bindings/pinctrl/pinctrl-bindings.txt      |  2 ++

Acked-by: Rob Herring <robh@kernel.org>

>  drivers/pinctrl/pinconf-generic.c                         |  3 +++
>  include/linux/pinctrl/pinconf-generic.h                   | 15 +++++++++++----
>  3 files changed, 16 insertions(+), 4 deletions(-)

Thread

[PATCH v2] pinctrl: generic: Add output-enable property Jacopo Mondi <jacopo+renesas@jmondi.org> - 2017-06-22 12:10 +0200
  Re: [PATCH v2] pinctrl: generic: Add output-enable property Rob Herring <robh@kernel.org> - 2017-06-26 20:50 +0200
  Re: [PATCH v2] pinctrl: generic: Add output-enable property Linus Walleij <linus.walleij@linaro.org> - 2017-06-29 14:40 +0200
    Re: [PATCH v2] pinctrl: generic: Add output-enable property Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-29 16:30 +0200

csiph-web