Re: [PATCH v4 1/3] tracing: Add support for recording tgid of tasks

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/3] tracing: Add support for recording tgid of tasks
Date	2017-06-26 21:30 +0200
Message-ID	<tWHRT-6oQ-5@gated-at.bofh.it> (permalink)
References	<tWuUG-6FZ-1@gated-at.bofh.it> <tWuUG-6FZ-15@gated-at.bofh.it> <tWFwK-4Os-21@gated-at.bofh.it> <tWHyy-6h8-15@gated-at.bofh.it> <tWHIe-6lD-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 26 Jun 2017 12:10:04 -0700
Joel Fernandes <joelaf@google.com> wrote:


> > That seems Ok with me to do, I think a valid point.
> >
> > I think that I should do it in the second call to
> > tracing_start_tgid_record too then (__ftrace_event_enable_disable) to
> > error out if the allocation fails.
> >
> > While going this code I again, I noticed another potential issue in
> > __ftrace_event_enable_disable  
> 
> Sorry I hit send too soon!
> 
> I was saying, While going through this code again I noticed another
> potential issue in __ftrace_event_enable_disable in existing code:
> 
> Here we do:
> ret = call->class->reg(call, TRACE_REG_REGISTER, file);
> 
> But in the error handling path we only do a
> tracing_stop_cmdline_record() and not clear the
> EVENT_FILE_FL_RECORDED_CMD_BIT flag. Is that not an issue? I am
> guessing because enabling of the event itself will fail, that's Ok.
> But just to keep it consistent, I am thinking if we should just clear
> the bit here.

Yeah, we should probably add some better error handling for failed
setting of events. But the tgid-map is low hanging fruit to get
right ;-)

-- Steve

Thread

[PATCH v4 0/3] tracing: Add support for recording tgid of tasks  Joel Fernandes <joelaf@google.com> - 2017-06-26 07:40 +0200
  [PATCH v4 3/3] tracing/ftrace: Add support to record and display tgid Joel Fernandes <joelaf@google.com> - 2017-06-26 07:40 +0200
    Re: [PATCH v4 3/3] tracing/ftrace: Add support to record and display tgid Joel Fernandes <joelaf@google.com> - 2017-06-27 05:20 +0200
  [PATCH v4 1/3] tracing: Add support for recording tgid of tasks Joel Fernandes <joelaf@google.com> - 2017-06-26 07:40 +0200
    Re: [PATCH v4 1/3] tracing: Add support for recording tgid of tasks Steven Rostedt <rostedt@goodmis.org> - 2017-06-26 19:00 +0200
      Re: [PATCH v4 1/3] tracing: Add support for recording tgid of tasks Steven Rostedt <rostedt@goodmis.org> - 2017-06-26 21:10 +0200
      Re: [PATCH v4 1/3] tracing: Add support for recording tgid of tasks Joel Fernandes <joelaf@google.com> - 2017-06-26 21:10 +0200
        Re: [PATCH v4 1/3] tracing: Add support for recording tgid of tasks Joel Fernandes <joelaf@google.com> - 2017-06-26 21:20 +0200
          Re: [PATCH v4 1/3] tracing: Add support for recording tgid of tasks Steven Rostedt <rostedt@goodmis.org> - 2017-06-26 21:30 +0200
        Re: [PATCH v4 1/3] tracing: Add support for recording tgid of tasks Joel Fernandes <joelaf@google.com> - 2017-06-26 21:20 +0200
        Re: [PATCH v4 1/3] tracing: Add support for recording tgid of tasks Steven Rostedt <rostedt@goodmis.org> - 2017-06-26 21:20 +0200
  [PATCH v4 2/3] tracing: Add support for display of tgid in trace output Joel Fernandes <joelaf@google.com> - 2017-06-26 07:40 +0200

csiph-web