Re: [PATCH 3/4] btrfs: Add zstd support

From	Nick Terrell <terrelln@fb.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] btrfs: Add zstd support
Date	2017-06-26 19:00 +0200
Message-ID	<tWFwJ-4Os-9@gated-at.bofh.it> (permalink)
References	<tVisx-27Z-3@gated-at.bofh.it> <tWl4Z-xr-11@gated-at.bofh.it> <tWnq9-1SG-3@gated-at.bofh.it> <tWBju-2iS-59@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Thanks for the clarification! I will fix the divisions.

On 6/26/17, 5:12 AM, "David Sterba" <dsterba@suse.cz> wrote:

    On Sun, Jun 25, 2017 at 11:30:22PM +0200, Adam Borowski wrote:
    > On Mon, Jun 26, 2017 at 03:03:17AM +0800, kbuild test robot wrote:
    > > Hi Nick,
    > > 
    > > url:    https://github.com/0day-ci/linux/commits/Nick-Terrell/lib-Add-xxhash-module/20170625-214344
    > > config: i386-allmodconfig (attached as .config)
    > > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
    > > reproduce:
    > >         # save the attached .config to linux build tree
    > >         make ARCH=i386 
    > > 
    > > All errors (new ones prefixed by >>):
    > > 
    > > >> ERROR: "__udivdi3" [lib/zstd/zstd_compress.ko] undefined!
    > >    ERROR: "__udivdi3" [fs/ufs/ufs.ko] undefined!
    > 
    > Just to save you time to figure it out:
    > for division when one or both arguments are longer than the architecture's
    > word, gcc uses helper functions that are included when compiling in a hosted
    > environment -- but not in freestanding.
    > 
    > Thus, you want do_div() instead of /; do check widths and signedness of
    > arguments.
    
    No do_div please, div_u64 or div64_u64.

Thread

[PATCH 3/4] btrfs: Add zstd support Nick Terrell <terrelln@fb.com> - 2017-06-23 00:10 +0200
  Re: [PATCH 3/4] btrfs: Add zstd support Adam Borowski <kilobyte@angband.pl> - 2017-06-25 23:40 +0200
    Re: [PATCH 3/4] btrfs: Add zstd support David Sterba <dsterba@suse.cz> - 2017-06-26 14:30 +0200
      Re: [PATCH 3/4] btrfs: Add zstd support Nick Terrell <terrelln@fb.com> - 2017-06-26 19:00 +0200
      [PATCH] lib/zstd: use div_u64() to let it build on 32-bit Adam Borowski <kilobyte@angband.pl> - 2017-06-27 06:30 +0200
        Re: [PATCH] lib/zstd: use div_u64() to let it build on 32-bit Nick Terrell <terrelln@fb.com> - 2017-06-27 07:30 +0200
          Re: [PATCH] lib/zstd: use div_u64() to let it build on 32-bit David Sterba <dsterba@suse.cz> - 2017-06-27 15:00 +0200
            Re: [PATCH] lib/zstd: use div_u64() to let it build on 32-bit Nick Terrell <terrelln@fb.com> - 2017-06-28 07:40 +0200
          Re: [PATCH] lib/zstd: use div_u64() to let it build on 32-bit Adam Borowski <kilobyte@angband.pl> - 2017-06-29 03:10 +0200
            [PATCH] btrfs: Keep one more workspace around Nick Terrell <terrelln@fb.com> - 2017-06-29 05:10 +0200
              Re: [PATCH] btrfs: Keep one more workspace around David Sterba <dsterba@suse.cz> - 2017-06-29 16:10 +0200

csiph-web