[PATCH] xen/x86: Don't BUG on CPU0 offlining

From	Vitaly Kuznetsov <vkuznets@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH] xen/x86: Don't BUG on CPU0 offlining
Date	2017-06-26 18:40 +0200
Message-ID	<tWFdo-4I2-23@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

CONFIG_BOOTPARAM_HOTPLUG_CPU0 allows to offline CPU0 but Xen HVM guests
BUG() in xen_teardown_timer(). Remove the BUG_ON(), this is probably a
leftover from ancient times when CPU0 hotplug was impossible, it works
just fine for HVM.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
- CPU0 hotplug is currently broken on x86, see
  https://lkml.org/lkml/2017/6/26/529
---
 arch/x86/xen/time.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index a1895a8..1ecb05d 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -309,7 +309,6 @@ static irqreturn_t xen_timer_interrupt(int irq, void *dev_id)
 void xen_teardown_timer(int cpu)
 {
 	struct clock_event_device *evt;
-	BUG_ON(cpu == 0);
 	evt = &per_cpu(xen_clock_events, cpu).evt;
 
 	if (evt->irq >= 0) {
-- 
2.9.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen/x86: Don't BUG on CPU0 offlining Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-06-26 18:40 +0200
  Re: [Xen-devel] [PATCH] xen/x86: Don't BUG on CPU0 offlining Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2017-06-28 17:50 +0200
    Re: [Xen-devel] [PATCH] xen/x86: Don't BUG on CPU0 offlining Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-06-28 20:00 +0200
      Re: [Xen-devel] [PATCH] xen/x86: Don't BUG on CPU0 offlining Juergen Groß <jgross@suse.com> - 2017-06-29 09:10 +0200

csiph-web