Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674951

Re: Spurious touchpad events with closed LID

Show all headers | View raw

On Mon, Jun 26, 2017 at 06:54:53PM +0200, Pali Rohár wrote:
> Hi!
> 
> When I'm using dock with external input devices (keyboard + mouse) and 
> LID is closed, I'm getting spurious touchpad events and random mouse 
> clicks and movements.
> 
> It is because top part of LID is above touchpad and probably generates 
> touch pushes.
> 
> Year (or two?) when I had conversation with ALPS people I was told that 
> Windows driver is automatically turning touchpad off when ACPI LID close 
> event is received (and similarly turn touchpad on).
> 
> Maybe Linux should do similar thing? Random movement or touchpad clicks 
> is really annoying. But I'm not sure if kernel or userspace should do 
> this job... What do you think?

It is a matter of policy (deciding when device is "usable") and this
should be controlled from userspace. Kernel should provide necessary
knobs for it though. For a long time I was saying that it should be done
at device core level, but I do not think we will ever get there.

On ChromeOS input devices export "inhibit" attribute that basically
overrides open/close count and prevents delivery of events to userspace,
and power management driver controls this attribute together with wake
up and others. This allows us to implement policies like "the touchpad
should only be active and a wakeup source while the device is in laptop
mode, but not in tablet or tent mode, or when lid is closed", "disable
keyboard in tablet mode or when list is closed", etc.

Drivers can also implement inhibit/uninhibit methods that can put
inhibited devices into lower power mode. I am not too happy with the
implementation (I'd like to see if we could merge inhibit/uninhibit and
open/close), that is why I haven't pushed it upstream yet.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Spurious touchpad events with closed LID Pali Rohár <pali.rohar@gmail.com> - 2017-06-26 19:00 +0200
  Re: Spurious touchpad events with closed LID Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-06-26 19:10 +0200
    Re: Spurious touchpad events with closed LID Pali Rohár <pali.rohar@gmail.com> - 2017-06-26 21:20 +0200
      Re: Spurious touchpad events with closed LID Pavel Machek <pavel@ucw.cz> - 2017-06-28 22:20 +0200
        Re: Spurious touchpad events with closed LID Bastien Nocera <hadess@hadess.net> - 2017-06-29 00:50 +0200
          Re: Spurious touchpad events with closed LID Pali Rohár <pali.rohar@gmail.com> - 2017-06-29 09:40 +0200
            Re: Spurious touchpad events with closed LID Pavel Machek <pavel@ucw.cz> - 2017-06-29 12:10 +0200
              Re: Spurious touchpad events with closed LID Pali Rohár <pali.rohar@gmail.com> - 2017-06-29 12:20 +0200
                Re: Spurious touchpad events with closed LID Pavel Machek <pavel@ucw.cz> - 2017-06-29 12:20 +0200
                Re: Spurious touchpad events with closed LID Pali Rohár <pali.rohar@gmail.com> - 2017-06-29 12:30 +0200
            Re: Spurious touchpad events with closed LID Bastien Nocera <hadess@hadess.net> - 2017-06-29 12:40 +0200

csiph-web