[PATCH 1/2] powerpc/fadump: return 0 on re-registration

From	Michal Suchanek <msuchanek@suse.de>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] powerpc/fadump: return 0 on re-registration
Date	2017-06-26 16:10 +0200
Message-ID	<tWCSf-3mD-23@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

When fadump is already registered return success.

Currently EEXIST is returned which is difficult to handle race-free in
userspace when shell scripts are used. If multiple writers are trying to
write '1' there is no difference in whichever succeeds so just return 0
to all.

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 arch/powerpc/kernel/fadump.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index 436aedf195ab..5a7355381dac 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -1214,7 +1214,6 @@ static ssize_t fadump_register_store(struct kobject *kobj,
 		break;
 	case '1':
 		if (fw_dump.dump_registered == 1) {
-			ret = -EEXIST;
 			goto unlock_out;
 		}
 		/* Register Firmware-assisted dump */
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] powerpc/fadump: return 0 on re-registration Michal Suchanek <msuchanek@suse.de> - 2017-06-26 16:10 +0200
  [PATCH 2/2] powerpc/fadump: use kstrtoint to handle sysfs store Michal Suchanek <msuchanek@suse.de> - 2017-06-26 16:10 +0200
  Re: [PATCH 1/2] powerpc/fadump: return 0 on re-registration Michal Suchánek <msuchanek@suse.de> - 2017-06-27 11:40 +0200

csiph-web