[tip:irq/core] genirq: Set irq masked state when initializing irq_desc

From	tip-bot for Jeffy Chen <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:irq/core] genirq: Set irq masked state when initializing irq_desc
Date	2017-06-26 16:10 +0200
Message-ID	<tWCSe-3mD-1@gated-at.bofh.it> (permalink)
References	<tWAx4-1L4-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit-ID:  d829b8fb2431595422289cfc210f0a955a8bec74
Gitweb:     http://git.kernel.org/tip/d829b8fb2431595422289cfc210f0a955a8bec74
Author:     Jeffy Chen <jeffy.chen@rock-chips.com>
AuthorDate: Mon, 26 Jun 2017 19:33:33 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 26 Jun 2017 14:05:41 +0200

genirq: Set irq masked state when initializing irq_desc

The irq default state is set to disabled when allocating irq desc, but the
masked state flag is not set. This is inconsistent vs. the state tracking
logic which is used to prevent unnecessary calls to hardware level irq chip
functions.

Set the masked state flag as well.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: tfiga@chromium.org
Cc: briannorris@chromium.org
Cc: dianders@chromium.org
Link: http://lkml.kernel.org/r/1498476814-12563-1-git-send-email-jeffy.chen@rock-chips.com

---
 kernel/irq/irqdesc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 35a95fa..948b50e 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -116,6 +116,7 @@ static void desc_set_defaults(unsigned int irq, struct irq_desc *desc, int node,
 	desc->irq_data.chip_data = NULL;
 	irq_settings_clr_and_set(desc, ~0, _IRQ_DEFAULT_INIT_FLAGS);
 	irqd_set(&desc->irq_data, IRQD_IRQ_DISABLED);
+	irqd_set(&desc->irq_data, IRQD_IRQ_MASKED);
 	desc->handle_irq = handle_bad_irq;
 	desc->depth = 1;
 	desc->irq_count = 0;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 1/2] genirq: Set irq masked state by default Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-26 13:40 +0200
  [tip:irq/core] genirq: Set irq masked state when initializing  irq_desc tip-bot for Jeffy Chen <tipbot@zytor.com> - 2017-06-26 16:10 +0200

csiph-web