Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674811

[tip:ras/core] RAS/CEC: Check the correct variable in the debugfs error handling

Show all headers | View raw

Commit-ID:  32288daf3f2439f57167c03cd679c2eba28923b7
Gitweb:     http://git.kernel.org/tip/32288daf3f2439f57167c03cd679c2eba28923b7
Author:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
AuthorDate: Mon, 26 Jun 2017 14:35:32 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 26 Jun 2017 15:58:57 +0200

RAS/CEC: Check the correct variable in the debugfs error handling

Check the correct variable when handling a potential error from
debugfs_create_file(). Most likely a copy-paste botch.

[ Rewrite commit message. ]
Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170623062440.6726-1-christophe.jaillet@wanadoo.fr

---
 drivers/ras/cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index 6aab46d..d0e5d6e 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -481,7 +481,7 @@ static int __init create_debugfs_nodes(void)
 
 	count = debugfs_create_file("count_threshold", S_IRUSR | S_IWUSR, d,
 				    &count_threshold, &count_threshold_ops);
-	if (!decay) {
+	if (!count) {
 		pr_warn("Error creating count_threshold debugfs node!\n");
 		goto err;
 	}

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] RAS: Fix an error checking test in 'create_debugfs_nodes()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-06-23 08:30 +0200
  Re: [PATCH] RAS: Fix an error checking test in  'create_debugfs_nodes()' Borislav Petkov <bp@suse.de> - 2017-06-23 10:20 +0200
  [tip:ras/core] RAS/CEC: Check the correct variable in the debugfs  error handling tip-bot for Christophe JAILLET <tipbot@zytor.com> - 2017-06-26 16:10 +0200

csiph-web