[PATCH 2/3] RAS/CEC: Check the correct variable in the debugfs error handling

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	[PATCH 2/3] RAS/CEC: Check the correct variable in the debugfs error handling
Date	2017-06-26 14:40 +0200
Message-ID	<tWBt7-2mb-13@gated-at.bofh.it> (permalink)
References	<tWBt7-2mb-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Check the correct variable when handling a potential error from
debugfs_create_file(). Most likely a copy-paste botch.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Link: http://lkml.kernel.org/r/20170623062440.6726-1-christophe.jaillet@wanadoo.fr
[ Rewrite commit message. ]
Signed-off-by: Borislav Petkov <bp@suse.de>
---
 drivers/ras/cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index 6aab46d91d33..d0e5d6ee882c 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -481,7 +481,7 @@ static int __init create_debugfs_nodes(void)
 
 	count = debugfs_create_file("count_threshold", S_IRUSR | S_IWUSR, d,
 				    &count_threshold, &count_threshold_ops);
-	if (!decay) {
+	if (!count) {
 		pr_warn("Error creating count_threshold debugfs node!\n");
 		goto err;
 	}
-- 
2.13.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 2/3] RAS/CEC: Check the correct variable in the debugfs error handling Borislav Petkov <bp@alien8.de> - 2017-06-26 14:40 +0200

csiph-web