Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674149

Re: [PATCH 1/3] pci: Add a generic, weakly-linked pcibios_fixup_bus

Show all headers | View raw

On Sat, 24 Jun 2017 02:34:06 PDT (-0700), geert@linux-m68k.org wrote:
> Hi Palmer,
>
> On Sat, Jun 24, 2017 at 3:50 AM, Palmer Dabbelt <palmer@dabbelt.com> wrote:
>> Multiple architectures define this as an empty function, and I'm adding
>> another one as part of the RISC-V port.  This adds a __weak version of
>> pci_fixup_bios and deletes the now obselete ones in a handful of ports.
>>
>> The only functional change should be that microblaze used to export
>> pcibios_fixup_bus.  None of the other architectures export this, so I
>> just dropped it.
>>
>> Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
>
> Given this is an empty function, wouldn't it make more sense to have
> a static inline in asm-generic, protected by #ifndef pcibios_fixup_bus?

I think the PCI people were considering changing this from a per-arch function
to a per-controller function, so I think the inline won't help any there.  I
think since they hope to eventually clean up all the __weak functions it fits a
bit better this way, but I'm really fine with anything here.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

pci: Add generic pcibios_{fixup_bus,align_resource} Palmer Dabbelt <palmer@dabbelt.com> - 2017-06-24 04:10 +0200
  [PATCH 2/3] pci: Add a generic, weakly-linked pcibios_align_resource Palmer Dabbelt <palmer@dabbelt.com> - 2017-06-24 04:10 +0200
    Re: [PATCH 2/3] pci: Add a generic, weakly-linked pcibios_align_resource Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-24 11:50 +0200
      Re: [PATCH 2/3] pci: Add a generic, weakly-linked pcibios_align_resource Palmer Dabbelt <palmer@dabbelt.com> - 2017-06-24 23:40 +0200
  [PATCH 1/3] pci: Add a generic, weakly-linked pcibios_fixup_bus Palmer Dabbelt <palmer@dabbelt.com> - 2017-06-24 04:10 +0200
    Re: [PATCH 1/3] pci: Add a generic, weakly-linked pcibios_fixup_bus Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-24 11:40 +0200
      Re: [PATCH 1/3] pci: Add a generic, weakly-linked pcibios_fixup_bus Palmer Dabbelt <palmer@dabbelt.com> - 2017-06-24 23:40 +0200
  [PATCH 3/3] arc: kernel/pcibios.c is empty, delete it Palmer Dabbelt <palmer@dabbelt.com> - 2017-06-24 04:10 +0200

csiph-web