Re: [PATCH][spi-next] spi: stm32: fix range limit checks on div

From	Amelie DELAUNAY <amelie.delaunay@st.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH][spi-next] spi: stm32: fix range limit checks on div
Date	2017-06-23 14:50 +0200
Message-ID	<tVwca-2bn-3@gated-at.bofh.it> (permalink)
References	<tVcwO-6Is-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/22/2017 05:41 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently the check for range limits on div is incorrect and will
> never return -EINVAL. Fix this by replacing && with ||
> 
> Detected by CoverityScan, CID#1446580 ("Structurally dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/spi/spi-stm32.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
> index 0553f61ab3b7..b75909e7b117 100644
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -262,7 +262,7 @@ static int stm32_spi_prepare_mbr(struct stm32_spi *spi, u32 speed_hz)
>   	 * no need to check it there.
>   	 * However, we need to ensure the following calculations.
>   	 */
> -	if ((div < SPI_MBR_DIV_MIN) &&
> +	if ((div < SPI_MBR_DIV_MIN) ||
>   	    (div > SPI_MBR_DIV_MAX))
>   		return -EINVAL;
>   
> 

Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][spi-next] spi: stm32: fix range limit checks on div Colin King <colin.king@canonical.com> - 2017-06-22 17:50 +0200
  Re: [PATCH][spi-next] spi: stm32: fix range limit checks on div Amelie DELAUNAY <amelie.delaunay@st.com> - 2017-06-22 18:00 +0200
    Re: [PATCH][spi-next] spi: stm32: fix range limit checks on div Colin Ian King <colin.king@canonical.com> - 2017-06-22 18:00 +0200
    Re: [PATCH][spi-next] spi: stm32: fix range limit checks on div Mark Brown <broonie@kernel.org> - 2017-06-23 13:20 +0200
  Re: [PATCH][spi-next] spi: stm32: fix range limit checks on div Amelie DELAUNAY <amelie.delaunay@st.com> - 2017-06-23 14:50 +0200

csiph-web