Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673390

Re: [PATCH v5 1/4] x86: switch atomic.h to use atomic-instrumented.h

Show all headers | View raw

* Dmitry Vyukov <dvyukov@google.com> wrote:

> On Thu, Jun 22, 2017 at 11:14 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Thu, 22 Jun 2017 16:14:16 +0200 Dmitry Vyukov <dvyukov@google.com> wrote:
> >
> >> Add arch_ prefix to all atomic operations and include
> >> <asm-generic/atomic-instrumented.h>. This will allow
> >> to add KASAN instrumentation to all atomic ops.
> >
> > This gets a large number of (simple) rejects when applied to
> > linux-next.  Can you please redo against -next?
> 
> 
> This is based on tip/locking tree. Ingo already took a part of these
> series. The plan is that he takes the rest, and this applies on
> tip/locking without conflicts.

Yeah, so I've taken the rest as well, it all looks very clean now. Should show up 
in the next -next, if it passes my (arguably limited) testing.

Andrew, is this workflow fine with you? You usually take KASAN patches, but I was 
unhappy with the atomics instrumention of the earlier patches, and ended up 
reviewing the followup variants, and felt that if I hinder a patchset I might as 
well test and apply it once I'm happy with them! ;-)

Should be a special exception for this series only.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/4] x86, kasan: add KASAN checks to atomic operations Dmitry Vyukov <dvyukov@google.com> - 2017-06-22 16:20 +0200
  [PATCH v5 4/4] asm-generic, x86: add comments for atomic instrumentation Dmitry Vyukov <dvyukov@google.com> - 2017-06-22 16:20 +0200
    [tip:locking/core] locking/atomic/x86, asm-generic: Add comments  for atomic instrumentation tip-bot for Dmitry Vyukov <tipbot@zytor.com> - 2017-06-23 16:10 +0200
  [PATCH v5 1/4] x86: switch atomic.h to use atomic-instrumented.h Dmitry Vyukov <dvyukov@google.com> - 2017-06-22 16:20 +0200
    Re: [PATCH v5 1/4] x86: switch atomic.h to use  atomic-instrumented.h Andrew Morton <akpm@linux-foundation.org> - 2017-06-22 23:20 +0200
      Re: [PATCH v5 1/4] x86: switch atomic.h to use atomic-instrumented.h Dmitry Vyukov <dvyukov@google.com> - 2017-06-23 10:30 +0200
        Re: [PATCH v5 1/4] x86: switch atomic.h to use atomic-instrumented.h Ingo Molnar <mingo@kernel.org> - 2017-06-23 11:00 +0200
          Re: [PATCH v5 1/4] x86: switch atomic.h to use  atomic-instrumented.h Andrew Morton <akpm@linux-foundation.org> - 2017-06-23 21:10 +0200
    [tip:locking/core] locking/atomic/x86: Switch atomic.h to use  atomic-instrumented.h tip-bot for Dmitry Vyukov <tipbot@zytor.com> - 2017-06-23 16:10 +0200

csiph-web