[PATCH 1/6] MIPS: do not use __GFP_REPEAT for order-0 request

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 1/6] MIPS: do not use __GFP_REPEAT for order-0 request
Date	2017-06-23 11:00 +0200
Message-ID	<tVsBA-8nM-13@gated-at.bofh.it> (permalink)
References	<tVsBz-8nM-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Michal Hocko <mhocko@suse.com>

3377e227af44 ("MIPS: Add 48-bit VA space (and 4-level page tables) for
4K pages.") has added a new __GFP_REPEAT user but using this flag
doesn't really make any sense for order-0 request which is the case here
because PUD_ORDER is 0. __GFP_REPEAT has historically effect only on
allocation requests with order > PAGE_ALLOC_COSTLY_ORDER.

This doesn't introduce any functional change. This is a preparatory
patch for later work which renames the flag and redefines its semantic.

Cc: Alex Belits <alex.belits@cavium.com>
Cc: David Daney <david.daney@cavium.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 arch/mips/include/asm/pgalloc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/include/asm/pgalloc.h b/arch/mips/include/asm/pgalloc.h
index a1bdb1ea5234..39b9f311c4ef 100644
--- a/arch/mips/include/asm/pgalloc.h
+++ b/arch/mips/include/asm/pgalloc.h
@@ -116,7 +116,7 @@ static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address)
 {
 	pud_t *pud;
 
-	pud = (pud_t *) __get_free_pages(GFP_KERNEL|__GFP_REPEAT, PUD_ORDER);
+	pud = (pud_t *) __get_free_pages(GFP_KERNEL, PUD_ORDER);
 	if (pud)
 		pud_init((unsigned long)pud, (unsigned long)invalid_pmd_table);
 	return pud;
-- 
2.11.0

Thread

[PATCH 0/6] mm: give __GFP_REPEAT a better semantic Michal Hocko <mhocko@kernel.org> - 2017-06-23 11:00 +0200
  [PATCH 1/6] MIPS: do not use __GFP_REPEAT for order-0 request Michal Hocko <mhocko@kernel.org> - 2017-06-23 11:00 +0200
    Re: [PATCH 1/6] MIPS: do not use __GFP_REPEAT for order-0 request Ralf Baechle <ralf@linux-mips.org> - 2017-06-23 12:30 +0200
    Re: [PATCH 1/6] MIPS: do not use __GFP_REPEAT for order-0 request Vlastimil Babka <vbabka@suse.cz> - 2017-06-26 11:40 +0200
  [PATCH 5/6] drm/i915: use __GFP_RETRY_MAYFAIL Michal Hocko <mhocko@kernel.org> - 2017-06-23 11:00 +0200
  [PATCH 6/6] mm, migration: do not trigger OOM killer when migrating memory Michal Hocko <mhocko@kernel.org> - 2017-06-23 11:00 +0200
    Re: [PATCH 6/6] mm, migration: do not trigger OOM killer when  migrating memory Andrew Morton <akpm@linux-foundation.org> - 2017-06-23 22:50 +0200
      Re: [PATCH 6/6] mm, migration: do not trigger OOM killer when  migrating memory Michal Hocko <mhocko@kernel.org> - 2017-06-26 07:30 +0200
    Re: [PATCH 6/6] mm, migration: do not trigger OOM killer when  migrating memory Vlastimil Babka <vbabka@suse.cz> - 2017-06-26 14:20 +0200
  [PATCH 4/6] mm: kvmalloc support __GFP_RETRY_MAYFAIL for all sizes Michal Hocko <mhocko@kernel.org> - 2017-06-23 11:00 +0200
    Re: [PATCH 4/6] mm: kvmalloc support __GFP_RETRY_MAYFAIL for all  sizes Vlastimil Babka <vbabka@suse.cz> - 2017-06-26 14:10 +0200
      Re: [PATCH 4/6] mm: kvmalloc support __GFP_RETRY_MAYFAIL for all  sizes Michal Hocko <mhocko@kernel.org> - 2017-06-26 14:20 +0200
  [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by __GFP_RETRY_MAYFAIL with more useful semantic Michal Hocko <mhocko@kernel.org> - 2017-06-23 11:00 +0200
    Re: [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by  __GFP_RETRY_MAYFAIL with more useful semantic Vlastimil Babka <vbabka@suse.cz> - 2017-06-26 13:50 +0200
      Re: [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by  __GFP_RETRY_MAYFAIL with more useful semantic Vlastimil Babka <vbabka@suse.cz> - 2017-06-26 14:20 +0200
        Re: [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by  __GFP_RETRY_MAYFAIL with more useful semantic Michal Hocko <mhocko@kernel.org> - 2017-06-26 14:40 +0200
          Re: [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by  __GFP_RETRY_MAYFAIL with more useful semantic Michal Hocko <mhocko@kernel.org> - 2017-06-26 14:50 +0200
      Re: [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by  __GFP_RETRY_MAYFAIL with more useful semantic Michal Hocko <mhocko@kernel.org> - 2017-06-26 14:20 +0200
    Re: [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by  __GFP_RETRY_MAYFAIL with more useful semantic Vlastimil Babka <vbabka@suse.cz> - 2017-06-26 14:00 +0200

csiph-web