Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673316

[PATCH] bcache: release the allocated id, not its multiple of BCACHE_MINORS

Show all headers | View raw

The id passed to ida_simple_remove has to be the one originally
allocated with ida_simple_get, not the one after multipling by
BCACHE_MINORS.

Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
---
 drivers/md/bcache/super.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index e57353e..9f64477 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -734,7 +734,8 @@ static void bcache_device_free(struct bcache_device *d)
 	if (d->disk && d->disk->queue)
 		blk_cleanup_queue(d->disk->queue);
 	if (d->disk) {
-		ida_simple_remove(&bcache_minor, d->disk->first_minor);
+		ida_simple_remove(&bcache_minor,
+				d->disk->first_minor / BCACHE_MINORS);
 		put_disk(d->disk);
 	}
 
@@ -784,7 +785,7 @@ static int bcache_device_init(struct bcache_device *d, unsigned block_size,
 
 	if (!(d->bio_split = bioset_create(4, offsetof(struct bbio, bio))) ||
 	    !(d->disk = alloc_disk(BCACHE_MINORS))) {
-		ida_simple_remove(&bcache_minor, minor);
+		ida_simple_remove(&bcache_minor, minor / BCACHE_MINORS);
 		return -ENOMEM;
 	}
 
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] bcache: release the allocated id, not its multiple of BCACHE_MINORS Liang Chen <liangchen.linux@gmail.com> - 2017-06-23 09:20 +0200
  Re: [PATCH] bcache: release the allocated id, not its multiple of  BCACHE_MINORS Coly Li <i@coly.li> - 2017-06-23 10:20 +0200
    Re: [PATCH] bcache: release the allocated id, not its multiple of BCACHE_MINORS Liang Chen <liangchen.linux@gmail.com> - 2017-06-23 13:40 +0200
  Re: [PATCH] bcache: release the allocated id, not its multiple of BCACHE_MINORS Liang Chen <liangchen.linux@gmail.com> - 2017-06-23 13:40 +0200

csiph-web