Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673300

Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry

From Andreas Dilger <adilger@dilger.ca>
Newsgroups linux.kernel
Subject Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry
Date 2017-06-23 09:00 +0200
Message-ID <tVqJr-7bI-1@gated-at.bofh.it> (permalink)
References <tVjHX-2OG-1@gated-at.bofh.it> <tVoHD-5Z8-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Jun 22, 2017, at 22:43, Theodore Ts'o <tytso@mit.edu> wrote:
> 
>> On Thu, Jun 22, 2017 at 04:23:07PM -0700, Khazhismel Kumykov wrote:
>> Previously, a read error would be ignored and we would eventually return
>> NULL from ext4_find_entry, which signals "no such file or directory". We
>> should be returning EIO.
>> 
>> Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
> 
> Thanks, applied.

I don't necessarily agree that this is an improvement. 

If the requested entry is not in the bad block, this will return an error even if the file name could be found in another block. It would be better to save the error until the end and only return -EIO if the entry cannot be found. 

Cheers, Andreas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ext4: Return EIO on read error in ext4_find_entry Khazhismel Kumykov <khazhy@google.com> - 2017-06-23 01:30 +0200
  Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Theodore Ts'o <tytso@mit.edu> - 2017-06-23 06:50 +0200
    Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Andreas Dilger <adilger@dilger.ca> - 2017-06-23 09:00 +0200
      Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Theodore Ts'o <tytso@mit.edu> - 2017-06-23 14:30 +0200
        Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Andreas Dilger <adilger@dilger.ca> - 2017-06-23 23:40 +0200
          Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Khazhismel Kumykov <khazhy@google.com> - 2017-06-24 00:40 +0200
            Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Theodore Ts'o <tytso@mit.edu> - 2017-06-24 01:30 +0200
              Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Andreas Dilger <adilger@dilger.ca> - 2017-06-24 01:40 +0200
                Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Theodore Ts'o <tytso@mit.edu> - 2017-06-24 02:30 +0200
                Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Tahsin Erdogan <tahsin@google.com> - 2017-06-26 21:30 +0200
                Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Andreas Dilger <adilger@dilger.ca> - 2017-06-26 22:50 +0200
        Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Pavel Machek <pavel@ucw.cz> - 2017-06-28 00:00 +0200

csiph-web