Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673268
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Namhyung Kim <namhyung@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | [PATCH/RFC 3/9] perf symbols: Discard symbols in kallsyms for loaded modules |
| Date | Fri, 23 Jun 2017 07:50:01 +0200 |
| Message-ID | <tVpDH-6AF-7@gated-at.bofh.it> (permalink) |
| References | <tVpDH-6AF-5@gated-at.bofh.it> |
| X-Original-To | Arnaldo Carvalho de Melo <acme@kernel.org> |
| X-Original-Senderip | 156.147.1.127 |
| X-Original-Mailfrom | namhyung@kernel.org |
| X-Original-Senderip | 10.177.227.17 |
| X-Original-Mailfrom | namhyung@kernel.org |
| X-Mailer | git-send-email 2.13.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>, kernel-team@lge.com, Masami Hiramatsu <mhiramat@kernel.org>, Andi Kleen <andi@firstfloor.org>, Adrian Hunter <adrian.hunter@intel.com>, Wang Nan <wangnan0@huawei.com> |
| X-Original-Date | Fri, 23 Jun 2017 14:48:21 +0900 |
| X-Original-Message-ID | <20170623054827.3828-4-namhyung@kernel.org> |
| X-Original-References | <20170623054827.3828-1-namhyung@kernel.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1673268 |
Show key headers only | View raw
If a module is already loaded, it should have symbols and no need to load new symbols from kallsyms. Actually kallsyms can have different addresses if the module was reloaded. Current code just discards the first symbols only, but it should do the same for all symbols in the module. Note that the kernel doesn't set the dso->loaded bit so simply checking it would do the job IMHO. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Wang Nan <wangnan0@huawei.com> Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/util/symbol.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index e7a98dbd2aed..74078ba595b3 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -787,11 +787,12 @@ static int dso__split_kallsyms(struct dso *dso, struct map *map, u64 delta) curr_map = map; goto discard_symbol; } - - if (curr_map->dso->loaded && - !machine__is_default_guest(machine)) - goto discard_symbol; } + + if (curr_map->dso->loaded && + !machine__is_default_guest(machine)) + goto discard_symbol; + /* * So that we look just like we get from .ko files, * i.e. not prelinked, relative to map->start. -- 2.13.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH/RFC 3/9] perf symbols: Discard symbols in kallsyms for loaded modules Namhyung Kim <namhyung@kernel.org> - 2017-06-23 07:50 +0200
Re: [PATCH/RFC 3/9] perf symbols: Discard symbols in kallsyms for loaded modules Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-23 16:00 +0200
Re: [PATCH/RFC 3/9] perf symbols: Discard symbols in kallsyms for loaded modules Namhyung Kim <namhyung@kernel.org> - 2017-06-25 15:50 +0200
csiph-web