Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1673240

[PATCH 04/11] net: stmmac: dwmac-rk: Remove unwanted code for rk3328_set_to_rmii()

From David Wu <david.wu@rock-chips.com>
Newsgroups linux.kernel
Subject [PATCH 04/11] net: stmmac: dwmac-rk: Remove unwanted code for rk3328_set_to_rmii()
Date 2017-06-23 06:50 +0200
Message-ID <tVoHD-5Z8-7@gated-at.bofh.it> (permalink)
References <tVoxX-5VY-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


This is wrong setting for rk3328_set_to_rmii(), so remove it.

Change-Id: I9953784ea44335d90710e5473960c95b3d68a5fd
Signed-off-by: David Wu <david.wu@rock-chips.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index f0df519..a8e8fd5 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -365,9 +365,6 @@ static void rk3328_set_to_rmii(struct rk_priv_data *bsp_priv)
 	regmap_write(bsp_priv->grf, RK3328_GRF_MAC_CON1,
 		     RK3328_GMAC_PHY_INTF_SEL_RMII |
 		     RK3328_GMAC_RMII_MODE);
-
-	/* set MAC to RMII mode */
-	regmap_write(bsp_priv->grf, RK3328_GRF_MAC_CON1, GRF_BIT(11));
 }
 
 static void rk3328_set_rgmii_speed(struct rk_priv_data *bsp_priv, int speed)
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/11] Add the mac internal ephy support David Wu <david.wu@rock-chips.com> - 2017-06-23 06:40 +0200
  [PATCH 03/11] arm64: defconfig: Enable CONFIG_ROCKCHIP_MAC_PHY David Wu <david.wu@rock-chips.com> - 2017-06-23 06:50 +0200
  [PATCH 04/11] net: stmmac: dwmac-rk: Remove unwanted code for rk3328_set_to_rmii() David Wu <david.wu@rock-chips.com> - 2017-06-23 06:50 +0200
    Re: [PATCH 04/11] net: stmmac: dwmac-rk: Remove unwanted code for  rk3328_set_to_rmii() Andrew Lunn <andrew@lunn.ch> - 2017-06-24 04:30 +0200
  [PATCH 09/11] ARM: dts: rk3228-evb: Enable the internal phy for gmac David Wu <david.wu@rock-chips.com> - 2017-06-23 07:00 +0200
  [PATCH 08/11] ARM: dts: rk322x: Add support internal phy for gmac David Wu <david.wu@rock-chips.com> - 2017-06-23 07:00 +0200
  [PATCH 07/11] net: stmmac: dwmac-rk: Add internal phy supprot for rk3328 David Wu <david.wu@rock-chips.com> - 2017-06-23 07:00 +0200
  [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support David Wu <david.wu@rock-chips.com> - 2017-06-23 07:00 +0200
    Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support Florian Fainelli <f.fainelli@gmail.com> - 2017-06-23 18:30 +0200
      Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support "David.Wu" <david.wu@rock-chips.com> - 2017-06-27 16:30 +0200
        Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support Andrew Lunn <andrew@lunn.ch> - 2017-06-27 17:00 +0200
    Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support Heiko Stuebner <heiko@sntech.de> - 2017-06-23 19:30 +0200
      Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support "David.Wu" <david.wu@rock-chips.com> - 2017-06-27 16:40 +0200
        Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support Heiko Stuebner <heiko@sntech.de> - 2017-06-27 17:50 +0200
    Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support Andrew Lunn <andrew@lunn.ch> - 2017-06-24 04:40 +0200
  [PATCH 06/11] net: stmmac: dwmac-rk: Add internal phy support for rk3228 David Wu <david.wu@rock-chips.com> - 2017-06-23 07:00 +0200
  [PATCH 10/11] ARM64: dts: rockchip: Add gmac2phy node support for rk3328 David Wu <david.wu@rock-chips.com> - 2017-06-23 07:10 +0200
  [PATCH 11/11] ARM64: dts: rockchip: Enable gmac2phy for rk3328-evb David Wu <david.wu@rock-chips.com> - 2017-06-23 07:10 +0200

csiph-web