Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback
Date	2017-06-23 06:10 +0200
Message-ID	<tVo4V-5HP-1@gated-at.bofh.it> (permalink)
References	<tV5F0-26c-19@gated-at.bofh.it> <tVnse-5g3-11@gated-at.bofh.it> <tVnVf-5pm-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> what should the Mac driver do when it receive the error? I assume that it
> will return it to userspace. because the rtnl_lock ensure only one ethtool
> is executing, if the function return error, it means some bug in the mac
> driver, am I right?

Yes, return it. It could be there are other use cases of loopback,
which are not protected by the rtnl_lock.

      Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback Lin Yun Sheng <linyunsheng@huawei.com> - 2017-06-22 10:30 +0200
  Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback Andrew Lunn <andrew@lunn.ch> - 2017-06-23 05:30 +0200
    Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback Yunsheng Lin <linyunsheng@huawei.com> - 2017-06-23 06:00 +0200
      Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback Andrew Lunn <andrew@lunn.ch> - 2017-06-23 06:10 +0200

csiph-web