Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1673170

Re: [PATCH] docs/memory-hotplug: adjust the explanation of valid_zones sysfs

From Wei Yang <richard.weiyang@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] docs/memory-hotplug: adjust the explanation of valid_zones sysfs
Date 2017-06-23 03:50 +0200
Message-ID <tVlTr-44m-3@gated-at.bofh.it> (permalink)
References <tV1L3-7Tp-5@gated-at.bofh.it> <tVf1D-8nK-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Jun 22, 2017 at 08:21:14PM +0200, Michal Hocko wrote:
>On Thu 22-06-17 12:18:44, Wei Yang wrote:
>[...]
>> -'valid_zones'     : read-only: designed to show which zones this memory block
>> -		    can be onlined to.
>> -		    The first column shows it's default zone.
>> +'valid_zones'     : read-only: shows different information based on state.
>> +		    When state is online, it is designed to show the
>> +		    zone name this memory block is onlined to.
>> +		    When state is offline, it is designed to show which zones
>> +		    this memory block can be onlined to.  The first column
>> +		    shows it's default zone.
>
>I do not think we really need to touch this. First of all the last
>sentence is not really correct. The ordering of zones doesn't tell which
>zone will be onlined by default. This is indeed a change of behavior of
>my patch. I am just not sure anybody depends on that. I can fix it up
>but again the old semantic was just awkward and I didn't feel like I
>should keep it. Also I plan to change this behavior again with planned
>patches. I would like to get rid of the non-overlapping zones
>restriction so the wording would have to change again.

Sure, look forward your up coming patches.

>
>That being said, let's keep the wording as it is now.
>
>Thanks!
>-- 
>Michal Hocko
>SUSE Labs

-- 
Wei Yang
Help you, Help me

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] docs/memory-hotplug: adjust the explanation of valid_zones sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-06-22 06:20 +0200
  Re: [PATCH] docs/memory-hotplug: adjust the explanation of  valid_zones sysfs Michal Hocko <mhocko@kernel.org> - 2017-06-22 20:30 +0200
    Re: [PATCH] docs/memory-hotplug: adjust the explanation of  valid_zones sysfs Wei Yang <richard.weiyang@gmail.com> - 2017-06-23 03:50 +0200

csiph-web