Re: [PATCH 1/2] clk: samsung: audss: Fix silent hang on Exynos4412 due to disabled EPLL

From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] clk: samsung: audss: Fix silent hang on Exynos4412 due to disabled EPLL
Date	2017-06-23 00:00 +0200
Message-ID	<tViiR-1PL-3@gated-at.bofh.it> (permalink)
References	<tUTaO-1YJ-9@gated-at.bofh.it> <tV7x8-3ll-9@gated-at.bofh.it> <tUTaO-1YJ-7@gated-at.bofh.it> <tV7x8-3ll-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/22, Sylwester Nawrocki wrote:
> On 06/21/2017 09:08 PM, Krzysztof Kozlowski wrote:
> >Similarly to commit f1e9203e2366 ("clk: samsung: Fix Exynos 5420 pinctrl
> >setup and clock disable failure due to domain being gated") for
> >Exynos5420, the Exynos4412 also requires that EPLL is not disabled.
> >Otherwise any access to MAUDIO block will silently halt.
> >
> >This was not visible before because EPLL on Exynos4 could not be
> >disabled before commit 6edfa11cb396 ("clk: samsung:
> >Add enable/disable operation for PLL36XX clocks").  After this commit,
> >on Odroid U3 board one can see silent hang, usually with last (but
> >unrelated) messages:
> >
> >	[    2.382741] input: gpio_keys as /devices/platform/gpio_keys/input/input0
> >	[    2.405686] usb 1-3: new high-speed USB device number 3 using exynos-ehci
> >	[    2.419843] max77686-rtc max77686-rtc: setting system clock to 2017-06-21 17:04:13 UTC (1498064653)
> >
> >Mark Exynos4 variant as also needed EPLL to be enabled all the time.
> >
> >Signed-off-by: Krzysztof Kozlowski<krzk@kernel.org>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 
> Stephen, Mike,
> 
> Can you please apply this patch directly?
> 

Applied to clk-next.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] clk: samsung: audss: Fix silent hang on Exynos4412 due to disabled EPLL Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-21 21:10 +0200
  Re: [PATCH 1/2] clk: samsung: audss: Fix silent hang on Exynos4412  due to disabled EPLL Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-06-22 12:30 +0200
    Re: [PATCH 1/2] clk: samsung: audss: Fix silent hang on Exynos4412  due to disabled EPLL Stephen Boyd <sboyd@codeaurora.org> - 2017-06-23 00:00 +0200

csiph-web