Re: [next-20170609] WARNING: CPU: 3 PID: 71167 at lib/idr.c:157 idr_replace

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [next-20170609] WARNING: CPU: 3 PID: 71167 at lib/idr.c:157 idr_replace
Date	2017-06-22 21:00 +0200
Message-ID	<tVfuF-5s-3@gated-at.bofh.it> (permalink)
References	<tRyPf-3kj-5@gated-at.bofh.it> <tRUwq-dH-33@gated-at.bofh.it> <tUXo6-4Jf-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 22, 2017 at 12:31:35AM +0100, Chris Wilson wrote:
> Quoting Tejun Heo (2017-06-13 14:58:49)
> > Cc'ing David Airlie.
> > 
> > This is from drm driver calling in idr_replace() w/ a negative id.
> > Probably a silly bug in error handling path?
> 
> No, this is the validation of an invalid userspace handle. The drm ABI
> for handles is supposed to be a full u32 range with 0 reserved for an
> invalid handle (constrained by the idr_alloc ofc). The WARN was
> introduced by 0a835c4f090a.

Matthew, did idr lost some of its range while being reimplemented
using radix tree?

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [next-20170609] WARNING: CPU: 3 PID: 71167 at lib/idr.c:157 idr_replace Chris Wilson <chris@chris-wilson.co.uk> - 2017-06-22 01:40 +0200
  Re: [next-20170609] WARNING: CPU: 3 PID: 71167 at lib/idr.c:157  idr_replace Tejun Heo <tj@kernel.org> - 2017-06-22 21:00 +0200

csiph-web