Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1672996

Re: [PATCH v2 2/2] x86/xen/efi: Init only efi struct members used by Xen

Path csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/2] x86/xen/efi: Init only efi struct members used by Xen
Date Thu, 22 Jun 2017 21:30:01 +0200
Message-ID <tVfXH-uK-7@gated-at.bofh.it> (permalink)
References <tV809-3zb-3@gated-at.bofh.it> <tV80a-3zb-21@gated-at.bofh.it>
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version 1.0
Content-Type text/plain; charset=windows-1252
Content-Transfer-Encoding 7bit
X-Source-IP aserv0021.oracle.com [141.146.126.233]
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 11
Organization linux.* mail to news gateway
X-Original-Cc jgross@suse.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, matt@codeblueprint.co.uk, ard.biesheuvel@linaro.org, andrew.cooper3@citrix.com
X-Original-Date Thu, 22 Jun 2017 15:25:28 -0400
X-Original-Message-ID <54b02bd1-b3a7-9154-f007-32bf4c27f553@oracle.com>
X-Original-References <1498128697-12943-1-git-send-email-daniel.kiper@oracle.com> <1498128697-12943-3-git-send-email-daniel.kiper@oracle.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1672996

Show key headers only | View raw


On 06/22/2017 06:51 AM, Daniel Kiper wrote:
> Current approach, wholesale efi struct initialization from efi_xen, is not
> good. Usually if new member is defined then it is properly initialized in
> drivers/firmware/efi/efi.c but not in arch/x86/xen/efi.c. As I saw it happened
> a few times until now. So, let's initialize only efi struct members used by
> Xen to avoid such issues in the future.
>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/2] xen/efi: Fixes Daniel Kiper <daniel.kiper@oracle.com> - 2017-06-22 13:00 +0200
  [PATCH v2 2/2] x86/xen/efi: Init only efi struct members used by Xen Daniel Kiper <daniel.kiper@oracle.com> - 2017-06-22 13:00 +0200
    Re: [PATCH v2 2/2] x86/xen/efi: Init only efi struct members used by  Xen Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-06-22 21:30 +0200
    [tip:efi/core] x86/xen/efi: Initialize only the EFI struct members  used by Xen tip-bot for Daniel Kiper <tipbot@zytor.com> - 2017-06-23 16:10 +0200

csiph-web