Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1672821

[tip:irq/core] genirq/msi: Prevent overwriting domain name

Show all headers | View raw

Commit-ID:  0165308a2f994939d2e1b36624f5a8f57746bc88
Gitweb:     http://git.kernel.org/tip/0165308a2f994939d2e1b36624f5a8f57746bc88
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Tue, 20 Jun 2017 01:37:04 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 22 Jun 2017 18:21:08 +0200

genirq/msi: Prevent overwriting domain name

Prevent overwriting an already assigned domain name. Remove the extra check
for chip->name, because if domain->name is NULL overwriting it with NULL is
not a problem.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>
Link: http://lkml.kernel.org/r/20170619235443.510684976@linutronix.de

---
 kernel/irq/msi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index fe4d48e..9e3f185 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -274,7 +274,8 @@ struct irq_domain *msi_create_irq_domain(struct fwnode_handle *fwnode,
 
 	domain = irq_domain_create_hierarchy(parent, IRQ_DOMAIN_FLAG_MSI, 0,
 					     fwnode, &msi_domain_ops, info);
-	if (domain && info->chip && info->chip->name)
+
+	if (domain && !domain->name && info->chip)
 		domain->name = info->chip->name;
 
 	return domain;

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch 00/55] genirq: Debuggability,  consolidation and managed affinities Thomas Gleixner <tglx@linutronix.de> - 2017-06-20 02:20 +0200
  [patch 01/55] x86/apic: Add name to irq chip Thomas Gleixner <tglx@linutronix.de> - 2017-06-20 02:20 +0200
    [tip:irq/core] x86/apic: Add name to irq chip tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-06-22 18:50 +0200
  [patch 04/55] genirq/msi: Prevent overwriting domain name Thomas Gleixner <tglx@linutronix.de> - 2017-06-20 02:20 +0200
    [tip:irq/core] genirq/msi: Prevent overwriting domain name tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-06-22 18:50 +0200
  Re: [patch 00/55] genirq: Debuggability, consolidation and managed         affinities Christoph Hellwig <hch@lst.de> - 2017-06-20 11:30 +0200

csiph-web