Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1672774

Re: [PATCH 30/32] ext4: eliminate xattr entry e_hash recalculation for removes

Show all headers | View raw

On Wed, Jun 21, 2017 at 06:49:37PM -0700, Tahsin Erdogan wrote:
> When an extended attribute block is modified, ext4_xattr_hash_entry()
> recalculates e_hash for the entry that is pointed by s->here. This is
> unnecessary if the modification is to remove an entry.
> 
> Currently, if the removed entry is the last one and there are other
> entries remaining, hash calculation targets the just erased entry which
> has been filled with zeroes and effectively does nothing. If the removed
> entry is not the last one and there are more entries, this time it will
> recalculate hash on the next entry which is totally unnecessary.
> 
> Fix these by moving the decision on when to recalculate hash to
> ext4_xattr_set_entry().
> 
> Signed-off-by: Tahsin Erdogan <tahsin@google.com>

Thanks, applied.

					- Ted

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 24/32] ext2, ext4: make mb block cache names more explicit Tahsin Erdogan <tahsin@google.com> - 2017-06-22 04:00 +0200
  [PATCH 26/32] ext4: cleanup transaction restarts during inode deletion Tahsin Erdogan <tahsin@google.com> - 2017-06-22 04:00 +0200
    Re: [PATCH 26/32] ext4: cleanup transaction restarts during inode  deletion Theodore Ts'o <tytso@mit.edu> - 2017-06-22 17:50 +0200
  [PATCH 25/32] ext4: add ext4_is_quota_file() Tahsin Erdogan <tahsin@google.com> - 2017-06-22 04:00 +0200
    Re: [PATCH 25/32] ext4: add ext4_is_quota_file() Theodore Ts'o <tytso@mit.edu> - 2017-06-22 17:40 +0200
  [PATCH 32/32] ext4: add nombcache mount option Tahsin Erdogan <tahsin@google.com> - 2017-06-22 04:00 +0200
    Re: [PATCH 32/32] ext4: add nombcache mount option Theodore Ts'o <tytso@mit.edu> - 2017-06-22 18:10 +0200
  [PATCH 30/32] ext4: eliminate xattr entry e_hash recalculation for removes Tahsin Erdogan <tahsin@google.com> - 2017-06-22 04:00 +0200
    Re: [PATCH 30/32] ext4: eliminate xattr entry e_hash recalculation  for removes Theodore Ts'o <tytso@mit.edu> - 2017-06-22 18:00 +0200
  [PATCH 31/32] ext4: strong binding of xattr inode references Tahsin Erdogan <tahsin@google.com> - 2017-06-22 04:00 +0200
    Re: [PATCH 31/32] ext4: strong binding of xattr inode references Theodore Ts'o <tytso@mit.edu> - 2017-06-22 18:00 +0200
  Re: [PATCH 24/32] ext2, ext4: make mb block cache names more explicit Theodore Ts'o <tytso@mit.edu> - 2017-06-22 17:40 +0200
  Re: [PATCH 27/32] ext4: xattr inode deduplication Theodore Ts'o <tytso@mit.edu> - 2017-06-22 18:00 +0200

csiph-web