Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

From	Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock
Date	2017-06-22 16:30 +0200
Message-ID	<tVbhp-5Uv-39@gated-at.bofh.it> (permalink)
References	<tVaEG-5pO-5@gated-at.bofh.it> <tVbhn-5Uv-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 22, 2017 at 03:19:27PM +0100, John Garry wrote:
> On 22/06/2017 14:43, Johannes Thumshirn wrote:
> >In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the
> >qpair->qp_lock but do access members of the qpair before having the lock.
> >Re-order the locking sequence to have all read and write access to qpair
> >members under the qpair->qp_lock.
> >
> >Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> >---
> > drivers/scsi/qla2xxx/qla_iocb.c | 20 +++++++++++++-------
> > 1 file changed, 13 insertions(+), 7 deletions(-)
> >
> >diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
> >index 8404f17f3c6c..425ca1646a9a 100644
> >--- a/drivers/scsi/qla2xxx/qla_iocb.c
> >+++ b/drivers/scsi/qla2xxx/qla_iocb.c
> >@@ -1770,10 +1770,6 @@ qla2xxx_start_scsi_mq(srb_t *sp)
> > 	struct qla_hw_data *ha = vha->hw;
> > 	struct qla_qpair *qpair = sp->qpair;
> >
> >-	/* Setup qpair pointers */
> >-	rsp = qpair->rsp;
> >-	req = qpair->req;
> 
> Can you check the call to qla2x00_marker() before the spinlock grab, which
> takes rsp and req as parameters?

Good catch, thanks.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-22 15:50 +0200
  Re: [PATCH] qla2xxx: Protect access to qpair members with  qpair->qp_lock Hannes Reinecke <hare@suse.de> - 2017-06-22 16:00 +0200
  Re: [PATCH] qla2xxx: Protect access to qpair members with  qpair->qp_lock John Garry <john.garry@huawei.com> - 2017-06-22 16:30 +0200
    Re: [PATCH] qla2xxx: Protect access to qpair members with  qpair->qp_lock Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-22 16:30 +0200

csiph-web