Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674085

Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH 01/11] net: phy: Add rockchip phy driver support
Date 2017-06-24 16:10 +0200
Message-ID <tVTV7-lO-3@gated-at.bofh.it> (permalink)
References <tVoxX-5VY-5@gated-at.bofh.it> <tVoxX-5VY-7@gated-at.bofh.it> <tVIQ1-1SY-9@gated-at.bofh.it> <tVOLN-5uL-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> hmm, we do have quite a number of non-net phys in the phy subsystem
> (DP, PCIe, ...) and given that the above would be CONFIG_ROCKCHIP_PHY
> in a global sense, sounds like it could make things confusing.
> 
> So some addition sounds reasonable ... ROCKCHIP_ETH_PHY or so?

I follow you reasoning, but generic phy is the new kid on the
block. It is well established that Ethernet PHYs are called
<MANUFACTURER>_PHY.

If you do want to consider generic phy, the logical name would be
ROCKCHIP_PHY_PHY, since generic phy postfixes with _SATA, _USB, _PCIE,
etc. But that does leave an issues when we have an Ethernet PHY which
needs a generic PHY. In some sense, SERDES could be considered as
something supported by a generic PHY...

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/11] net: phy: Add rockchip phy driver support David Wu <david.wu@rock-chips.com> - 2017-06-23 06:40 +0200
  Re: [PATCH 01/11] net: phy: Add rockchip phy driver support Andrew Lunn <andrew@lunn.ch> - 2017-06-23 16:00 +0200
  Re: [PATCH 01/11] net: phy: Add rockchip phy driver support Florian Fainelli <f.fainelli@gmail.com> - 2017-06-23 18:20 +0200
  Re: [PATCH 01/11] net: phy: Add rockchip phy driver support Andrew Lunn <andrew@lunn.ch> - 2017-06-24 04:20 +0200
    Re: [PATCH 01/11] net: phy: Add rockchip phy driver support Heiko Stuebner <heiko@sntech.de> - 2017-06-24 10:40 +0200
      Re: [PATCH 01/11] net: phy: Add rockchip phy driver support Andrew Lunn <andrew@lunn.ch> - 2017-06-24 16:10 +0200
        Re: [PATCH 01/11] net: phy: Add rockchip phy driver support Heiko Stuebner <heiko@sntech.de> - 2017-06-24 18:10 +0200
    Re: [PATCH 01/11] net: phy: Add rockchip phy driver support "David.Wu" <david.wu@rock-chips.com> - 2017-06-27 16:50 +0200
      Re: [PATCH 01/11] net: phy: Add rockchip phy driver support Andrew Lunn <andrew@lunn.ch> - 2017-06-27 16:50 +0200
        Re: [PATCH 01/11] net: phy: Add rockchip phy driver support "David.Wu" <david.wu@rock-chips.com> - 2017-06-27 17:20 +0200
  Re: [PATCH 01/11] net: phy: Add rockchip phy driver support Andrew Lunn <andrew@lunn.ch> - 2017-06-24 04:20 +0200

csiph-web