Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674050

Re: [PATCH] usb: core: sysfs: constify attribute_group

Show all headers | View raw

On Fri, Jun 23, 2017 at 11:28:10AM +0530, Arvind Yadav wrote:
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    6798	   2848	      4	   9650	   25b2	drivers/usb/core/sysfs.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    7230	   2400	      4	   9634	   25a2	drivers/usb/core/sysfs.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

You have sent a lot of these types of patches out, and really, this is a
horrible changelog entry.  You are assuming that I know what this is,
and why it is a good thing.  Now I might, but maybe not...

Please actually explain why you are making this change.  Why it is
needed.  And big hint, it's not only about the output of the file
size...

Please fix this up for all of the patches you have sent me in this
format, as I'm deleting them all from my queue right now.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: core: sysfs: constify attribute_group Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-23 08:00 +0200
  Re: [PATCH] usb: core: sysfs: constify attribute_group Greg KH <gregkh@linuxfoundation.org> - 2017-06-24 10:00 +0200

csiph-web