Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673964

[PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

Show all headers | View raw

Fix to call of_node_put() right after of_drm_find_bridge() instead of
holding on to it until exynos_dsi_remove().

Suggested-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index e337cd2..7513b88 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1689,6 +1689,7 @@ static int exynos_dsi_bind(struct device *dev, struct device *master,
 
 	if (dsi->bridge_node) {
 		bridge = of_drm_find_bridge(dsi->bridge_node);
+		of_node_put(dsi->bridge_node);
 		if (bridge)
 			drm_bridge_attach(encoder, bridge, NULL);
 	}
@@ -1807,10 +1808,6 @@ static int exynos_dsi_probe(struct platform_device *pdev)
 
 static int exynos_dsi_remove(struct platform_device *pdev)
 {
-	struct exynos_dsi *dsi = platform_get_drvdata(pdev);
-
-	of_node_put(dsi->bridge_node);
-
 	pm_runtime_disable(&pdev->dev);
 
 	component_del(&pdev->dev, &exynos_dsi_component_ops);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge() Shuah Khan <shuahkh@osg.samsung.com> - 2017-06-24 03:00 +0200
  Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after  of_drm_find_bridge() Andrzej Hajda <a.hajda@samsung.com> - 2017-06-26 09:10 +0200
    Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after  of_drm_find_bridge() Inki Dae <inki.dae@samsung.com> - 2017-06-27 11:20 +0200
      Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after  of_drm_find_bridge() Andrzej Hajda <a.hajda@samsung.com> - 2017-06-27 12:10 +0200

csiph-web