Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673882
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Richard Henderson <rth@twiddle.net> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/3] alpha: Fix typo in ev6-copy_user.S |
| Date | Fri, 23 Jun 2017 23:30:02 +0200 |
| Message-ID | <tVEjo-7nt-11@gated-at.bofh.it> (permalink) |
| References | <tVEjo-7nt-13@gated-at.bofh.it> |
| X-Original-To | linux-kernel@vger.kernel.org |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=nXI+RmrsHj2EdeWjiHChME6yLcHmyeuVIh6CSZQGYlo=; b=Q007c7RzyxXOAUrZ54XHLItwXSANaxSEGBtcejTRhFphkeoI51YvYA9tTdRB4KLAVS u06pCA25V9UnCV7pEjW7dnM3FUfUFDsJx+k1lxKuxu/VhrNXF9skEbfdJT3hlf71puTI U00qcjJZRP4baWl+Xxl1wLa8we4FdNZeGLnG/hhA1ae1wVDzGAARxGUVRUBS9N5/IW2D ONpU1B1n6OIRds5b2w6PE9Pc9eNwlEazsfVOJQThI3WRWa9twuBhMg9j9Ou+jDHyn093 6bok9QtPN9CT4v6BVFFF80RPagWNdSiQ3X6zUDqfqORy87ewjeykIyw7O92u5W1k9KRq e4og== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=nXI+RmrsHj2EdeWjiHChME6yLcHmyeuVIh6CSZQGYlo=; b=R8kFpJOSvCe3HUJyKleAYSt4vbIqLQlRCMBIz8aTcpqAjcZJJz96Wtbd+uCGtUEr2b 4y3cOazj0KBF2FcPheAI6jz7HBIEo2k384YCXlDsWFBWMFNNcoAOaKzLSSdUCVSVHJCZ BQXnOankoXekjieWqp4QRHDcQpcc+z67lzDWgp3xMQYwfcCxV1hxK/rbcCH16PMDuBcJ /k0cTWhwHenzYT/0suQ6uuGUud9rbkTMPHZK45bUazUwXP6TbGVV+7TlS5RgvcfS984k 11jguJqni4BpHY40Ur1ONhLKJfcoeyJwWIBwZ/U3qPBIlNSIP6xptCN3dxh8Csc53QfX +6cw== |
| X-Gm-Message-State | AKS2vOxGyL8UYxt2o1UsmUi+eWFHHC+01gRp66YF4jdQ+0tTo3fgSwvt RWAbI6iIGIPmlg/IsQ4= |
| X-Received | by 10.55.186.66 with SMTP id k63mr2063729qkf.243.1498252809921; Fri, 23 Jun 2017 14:20:09 -0700 (PDT) |
| X-Mailer | git-send-email 2.9.4 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 45 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-alpha@vger.kernel.org |
| X-Original-Date | Fri, 23 Jun 2017 14:20:01 -0700 |
| X-Original-Message-ID | <20170623212001.2785-4-rth@twiddle.net> |
| X-Original-References | <20170623212001.2785-1-rth@twiddle.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1673882 |
Show key headers only | View raw
Patch 8525023121de4848b5f0a7d867ffeadbc477774d introduced a typo. That said, the identity AND insns added by that patch are more clearly written as MOV. At the same time, re-schedule the ev6 version so that the first dispatch can execute in parallel. Signed-off-by: Richard Henderson <rth@twiddle.net> --- arch/alpha/lib/copy_user.S | 2 +- arch/alpha/lib/ev6-copy_user.S | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/alpha/lib/copy_user.S b/arch/alpha/lib/copy_user.S index 159f1b7..c277a1a 100644 --- a/arch/alpha/lib/copy_user.S +++ b/arch/alpha/lib/copy_user.S @@ -34,7 +34,7 @@ .ent __copy_user __copy_user: .prologue 0 - and $18,$18,$0 + mov $18,$0 and $16,7,$3 beq $0,$35 beq $3,$36 diff --git a/arch/alpha/lib/ev6-copy_user.S b/arch/alpha/lib/ev6-copy_user.S index 35e6710..954ca03 100644 --- a/arch/alpha/lib/ev6-copy_user.S +++ b/arch/alpha/lib/ev6-copy_user.S @@ -45,9 +45,10 @@ # Pipeline info: Slotting & Comments __copy_user: .prologue 0 - andq $18, $18, $0 - subq $18, 32, $1 # .. E .. .. : Is this going to be a small copy? - beq $0, $zerolength # U .. .. .. : U L U L + mov $18, $0 # .. .. .. E + subq $18, 32, $1 # .. .. E. .. : Is this going to be a small copy? + nop # .. E .. .. + beq $18, $zerolength # U .. .. .. : U L U L and $16,7,$3 # .. .. .. E : is leading dest misalignment ble $1, $onebyteloop # .. .. U .. : 1st branch : small amount of data -- 2.9.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 3/3] alpha: Fix typo in ev6-copy_user.S Richard Henderson <rth@twiddle.net> - 2017-06-23 23:30 +0200
csiph-web