Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673894

Re: [PATCH v3 15/15] spi: qup: support for qup v1 dma

Show all headers | View raw

On Tue, Jun 20, 2017 at 02:40:57PM +0530, Varadarajan Narayanan wrote:
> Currently the QUP Version v1 does not work with DMA so added
> the support for the same.
> 
> 1. It uses ADM DMA which requires TX and RX CRCI
> 2. DMA channel initialization need to be done after setting
>    block size for having valid values in maxburst
> 3. QUP mode should be DMOV instead of BAM.
> 
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> Signed-off-by: Varadarajan Narayanan <varada@codeaurora.org>
> ---
>  .../devicetree/bindings/spi/qcom,spi-qup.txt       |  6 ++++
>  drivers/spi/spi-qup.c                              | 35 +++++++++++++++++-----
>  2 files changed, 34 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> index 5c09077..e754181 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> @@ -38,6 +38,12 @@ Optional properties:
>  - dma-names:    Names for the dma channels, if present. There must be at
>                  least one channel named "tx" for transmit and named "rx" for
>                  receive.
> +- qcom,tx-crci: Identificator for Client Rate Control Interface (CRCI) to be

Identificator is not a word.

This sounds like something that should be a cell in the dmas property.

> +		used with TX DMA channel. Required when using DMA for
> +		transmission with QUP Version 1 i.e qcom,spi-qup-v1.1.1.
> +- qcom,rx-crci: Identificator for Client Rate Control Interface (CRCI) to be
> +		used with RX DMA channel. Required when using DMA for
> +		receiving with QUP Version 1 i.e qcom,spi-qup-v1.1.1.
>  
>  SPI slave nodes must be children of the SPI master node and can contain
>  properties described in Documentation/devicetree/bindings/spi/spi-bus.txt

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/15] spi: qup: Fixes and add support for >64k transfers Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-20 11:20 +0200
  [PATCH v3 11/15] spi: qup: allow block mode to generate multiple transactions Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-20 11:20 +0200
  [PATCH v3 06/15] spi: qup: Fix error handling in spi_qup_prep_sg Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-20 11:20 +0200
  [PATCH v3 14/15] spi: qup: Ensure done detection Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-20 11:20 +0200
  [PATCH v3 15/15] spi: qup: support for qup v1 dma Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-20 11:20 +0200
    Re: [PATCH v3 15/15] spi: qup: support for qup v1 dma Rob Herring <robh@kernel.org> - 2017-06-23 23:50 +0200
      Re: [PATCH v3 15/15] spi: qup: support for qup v1 dma Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-27 11:40 +0200
      Re: [PATCH v3 15/15] spi: qup: support for qup v1 dma Andy Gross <andy.gross@linaro.org> - 2017-06-28 08:50 +0200
  [PATCH v3 07/15] spi: qup: Fix transaction done signaling Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-20 11:20 +0200
  [PATCH v3 05/15] spi: qup: Place the QUP in run mode before DMA Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-20 11:30 +0200
  [PATCH v3 04/15] spi: qup: Add completion timeout Varadarajan Narayanan <varada@codeaurora.org> - 2017-06-20 11:30 +0200

csiph-web