Re: [PATCH] staging: rtl8192u: ieee80211: Convert printks to pr_<level>

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: rtl8192u: ieee80211: Convert printks to pr_<level>
Date	2017-06-23 22:30 +0200
Message-ID	<tVDnk-6P1-23@gated-at.bofh.it> (permalink)
References	<tUMM2-5Yh-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 21, 2017 at 05:49:32PM +0530, simran singhal wrote:
> Use the current logging style.
> Coalesce formats where appropriate.
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 34 ++++++++++-------------
>  1 file changed, 14 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 7a31510..d1a86bb 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -236,8 +236,8 @@ ieee80211_rx_frame_mgmt(struct ieee80211_device *ieee, struct sk_buff *skb,
>  
>  	#ifdef NOT_YET
>  	if (ieee->iw_mode == IW_MODE_MASTER) {
> -		printk(KERN_DEBUG "%s: Master mode not yet supported.\n",
> -		       ieee->dev->name);
> +		pr_debug("%s: Master mode not yet supported.\n",
> +			 ieee->dev->name);

This is a network driver, why not use net_dbg() or at the very least,
dev_dbg(), which all drivers should use (never use pr_* or printk in a
driver if at all possible.)

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8192u: ieee80211: Convert printks to pr_<level> simran singhal <singhalsimran0@gmail.com> - 2017-06-21 14:20 +0200
  Re: [PATCH] staging: rtl8192u: ieee80211: Convert printks to  pr_<level> Joe Perches <joe@perches.com> - 2017-06-21 18:40 +0200
  Re: [PATCH] staging: rtl8192u: ieee80211: Convert printks to  pr_<level> Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-23 22:30 +0200

csiph-web