Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673799
| From | Jonathan Corbet <corbet@lwn.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/5] Docs: Remove redundant geometry package inclusion |
| Date | 2017-06-23 21:50 +0200 |
| Message-ID | <tVCKC-6lJ-7@gated-at.bofh.it> (permalink) |
| References | <tTS78-3fw-1@gated-at.bofh.it> <tTS78-3fw-11@gated-at.bofh.it> <tU2ga-1qR-17@gated-at.bofh.it> <tU2pQ-1ul-7@gated-at.bofh.it> |
| Organization | LWN.net |
On Mon, 19 Jun 2017 07:49:06 -0300
Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:
> There's a catch, though: as sphinxsetup hmargin/vmargin was added
> only on Sphinx version 1.5.3, the enclosed patch won't adjust the
> margins for versions 1.5.0 to 1.5.2. While I didn't test, I bet it
> will just ignore the keys, showing some warning.
And people routinely accuse *me* of being overly optimistic...
> ! Package keyval Error: hmargin undefined.
>
> See the keyval package documentation for explanation.
> Type H <return> for immediate help.
> ...
>
> l.19 \sphinxsetup{hmargin=0.5in, vmargin=0.5in}
>
> ?
So it kills the build on 1.5.2.
I've made a tweak to special-case early 1.5.x.
> Fixes: 85c21e5c3ee74fb75d690c57f7066bae7e2dca55
> Sighed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Sighed-off-by indeed, I agree. It's a good thing there's a lot of beer in
the fridge...
jon
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH 2/5] Docs: Remove redundant geometry package inclusion Jonathan Corbet <corbet@lwn.net> - 2017-06-23 21:50 +0200 Re: [PATCH 2/5] Docs: Remove redundant geometry package inclusion Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-06-23 23:30 +0200
csiph-web