Re: [PATCH v2] fs: warn in case userspace lied about modprobe return

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] fs: warn in case userspace lied about modprobe return
Date	Fri, 23 Jun 2017 20:30:02 +0200
Message-ID	<tVBvc-5CD-13@gated-at.bofh.it> (permalink)
References	<tNCHL-61B-3@gated-at.bofh.it> <tNCHL-61B-1@gated-at.bofh.it> <tUypJ-52u-63@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.0 (2016-04-01)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, jeyu@redhat.com, mcgrof@kernel.org
X-Original-Date	Fri, 23 Jun 2017 20:27:32 +0200
X-Original-Message-ID	<20170623182732.GQ21846@wotan.suse.de>
X-Original-References	<lkml.kernel.org/r/20170601180347.GL8951@wotan.suse.de> <20170601180801.19827-1-mcgrof@kernel.org> <20170620205746.GY21846@wotan.suse.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1673758

Show key headers only | View raw

On Tue, Jun 20, 2017 at 10:57:46PM +0200, Luis R. Rodriguez wrote:
> On Thu, Jun 01, 2017 at 11:08:01AM -0700, Luis R. Rodriguez wrote:
> > kmod <= v19 was broken -- it could return 0 to modprobe calls,
> > incorrectly assuming that a kernel module was built-in, whereas in
> > reality the module was just forming in the kernel. The reason for this
> > is an incorrect userspace heuristics. A userspace kmod fix is available
> > for it [0], however should userspace break again we could go on with
> > an failed get_fs_type() which is hard to debug as the request_module()
> > is detected as returning 0. The first suspect would be that there is
> > something worth with the kernel's module loader and obviously in this
> > case that is not the issue.
> > 
> > Since these issues are painful to debug complain when we know userspace
> > has outright lied to us.
> > 
> > [0] http://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/libkmod/libkmod-module.c?id=fd44a98ae2eb5eb32161088954ab21e58e19dfc4
> > 
> > Suggested-by: Rusty Russell <rusty@rustcorp.com.au>
> > Cc: Jessica Yu <jeyu@redhat.com>
> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> 
> *poke* Al?

Will bounce to the default tree maintainer, Andrew :)

  Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] fs: warn in case userspace lied about modprobe return "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-20 23:00 +0200
  Re: [PATCH v2] fs: warn in case userspace lied about modprobe return "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-23 20:30 +0200

csiph-web