Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673766
| From | Heiko Stuebner <heiko@sntech.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] arm64: dts: rockchip: set rk3399 dynamic CPU power coefficients |
| Date | 2017-06-23 20:40 +0200 |
| Message-ID | <tVBET-5G1-37@gated-at.bofh.it> (permalink) |
| References | <tVAfL-4XT-11@gated-at.bofh.it> <tVAfM-4XT-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Am Freitag, 23. Juni 2017, 10:07:37 CEST schrieb Brian Norris:
> Provide the dynamic power coefficient of the big and little CPU
> clusters. These numbers are currently in use on the Samsung Chromebook
> Plus ("Kevin").
>
> The power allocator thermal governor doesn't know how to do anything if
> it doesn't get power parameters from its cooling devices (in this case,
> CPUfreq). So this effectively enables the power-allocator governor.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 69c56f7316c4..4f6667547814 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -109,6 +109,7 @@
> reg = <0x0 0x0>;
> enable-method = "psci";
> #cooling-cells = <2>; /* min followed by max */
> + dynamic-power-coefficient = <100>;
> clocks = <&cru ARMCLKL>;
> };
>
> @@ -142,6 +143,7 @@
> reg = <0x0 0x100>;
> enable-method = "psci";
> #cooling-cells = <2>; /* min followed by max */
> + dynamic-power-coefficient = <100>;
> clocks = <&cru ARMCLKB>;
> };
>
>
I think these should be set for all cores, similar to clocks. While
cpufreq and friends regularly only take the first number, in a
hw-description sense, it should be part of every core in the dt.
Heiko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] arm64: dts: rockchip: Update CPU regulator voltage ranges for Gru Brian Norris <briannorris@chromium.org> - 2017-06-23 19:10 +0200
[PATCH 3/3] arm64: dts: rockchip: set rk3399 dynamic CPU power coefficients Brian Norris <briannorris@chromium.org> - 2017-06-23 19:10 +0200
Re: [PATCH 3/3] arm64: dts: rockchip: set rk3399 dynamic CPU power coefficients Heiko Stuebner <heiko@sntech.de> - 2017-06-23 20:40 +0200
Re: [PATCH 3/3] arm64: dts: rockchip: set rk3399 dynamic CPU power coefficients Heiko Stuebner <heiko@sntech.de> - 2017-06-23 21:00 +0200
Re: [PATCH 3/3] arm64: dts: rockchip: set rk3399 dynamic CPU power coefficients Brian Norris <briannorris@chromium.org> - 2017-06-23 21:00 +0200
Re: [PATCH 3/3] arm64: dts: rockchip: set rk3399 dynamic CPU power coefficients Heiko Stuebner <heiko@sntech.de> - 2017-06-28 17:50 +0200
[PATCH 2/3] arm64: dts: rockchip: Use vctrl regulators for dynamic CPU voltages on Gru/Kevin Brian Norris <briannorris@chromium.org> - 2017-06-23 19:10 +0200
Re: [PATCH 2/3] arm64: dts: rockchip: Use vctrl regulators for dynamic CPU voltages on Gru/Kevin Heiko Stuebner <heiko@sntech.de> - 2017-06-28 17:50 +0200
Re: [PATCH 2/3] arm64: dts: rockchip: Use vctrl regulators for dynamic CPU voltages on Gru/Kevin Brian Norris <briannorris@chromium.org> - 2017-06-29 23:00 +0200
Re: [PATCH 1/3] arm64: dts: rockchip: Update CPU regulator voltage ranges for Gru Heiko Stuebner <heiko@sntech.de> - 2017-06-28 17:50 +0200
csiph-web