Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673699

Re: Applied "spi: atmel: fix corrupted data issue on SAM9 family SoCs" to the spi tree

Show all headers | View raw

On Fri, Jun 23, 2017 at 05:15:58PM +0100, Mark Brown wrote:
> +#ifdef CONFIG_SOC_SAM_V4_V5
> +	/*
> +	 * Atmel SoCs based on ARM9 (SAM9x) cores should not use spi_map_buf()
> +	 * since this later function tries to map buffers with dma_map_sg()
> +	 * even if they have not been allocated inside DMA-safe areas.
> +	 * On SoCs based on Cortex A5 (SAMA5Dx), it works anyway because for
> +	 * those ARM cores, the data cache follows the PIPT model.
> +	 * Also the L2 cache controller of SAMA5D2 uses the PIPT model too.
> +	 * In case of PIPT caches, there cannot be cache aliases.
> +	 * However on ARM9 cores, the data cache follows the VIVT model, hence
> +	 * the cache aliases issue can occur when buffers are allocated from
> +	 * DMA-unsafe areas, by vmalloc() for instance, where cache coherency is
> +	 * not taken into account or at least not handled completely (cache
> +	 * lines of aliases are not invalidated).

There is a solution to this - code (iow, callers of functions that perform
IO) are expected to use flush_kernel_vmap_range() and
invalidate_kernel_vmap_range() as documented in Documentation/cachetlb.txt
to ensure that their "special" views are properly handled.

These are no-ops for PIPT caches, but aliasing caches have to implement
them.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] spi: atmel: fix corrupted data issue on SAM9 family SoCs Cyrille Pitchen <cyrille.pitchen@microchip.com> - 2017-06-23 17:40 +0200
  Re: [PATCH 1/1] spi: atmel: fix corrupted data issue on SAM9 family  SoCs Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-06-23 17:50 +0200
  Applied "spi: atmel: fix corrupted data issue on SAM9 family SoCs" to the spi tree Mark Brown <broonie@kernel.org> - 2017-06-23 18:20 +0200
    Re: Applied "spi: atmel: fix corrupted data issue on SAM9 family  SoCs" to the spi tree Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-23 19:20 +0200
      Re: Applied "spi: atmel: fix corrupted data issue on SAM9 family  SoCs" to the spi tree Cyrille Pitchen <cyrille.pitchen@microchip.com> - 2017-06-27 11:10 +0200
        Re: Applied "spi: atmel: fix corrupted data issue on SAM9 family  SoCs" to the spi tree Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-27 11:30 +0200

csiph-web