Re: [PATCH 2/2] ARM: cpuidle: Support asymmetric idle definition

From	Daniel Lezcano <daniel.lezcano@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ARM: cpuidle: Support asymmetric idle definition
Date	2017-06-22 14:30 +0200
Message-ID	<tV9pg-4DF-27@gated-at.bofh.it> (permalink)
References	<tRzV1-40Z-35@gated-at.bofh.it> <tRzV1-40Z-33@gated-at.bofh.it> <tRzV1-40Z-49@gated-at.bofh.it> <tRCJc-5Vh-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/06/2017 20:49, Rafael J. Wysocki wrote:
> On Monday, June 12, 2017 05:55:10 PM Daniel Lezcano wrote:
>> Some hardware have clusters with different idle states. The current code does
>> not support this and fails as it expects all the idle states to be identical.
>>
>> Because of this, the Mediatek mtk8173 had to create the same idle state for a
>> big.Little system and now the Hisilicon 960 is facing the same situation.
>>
>> Solve this by simply assuming the multiple driver will be needed for all the
>> platforms using the ARM generic cpuidle driver which makes sense because of the
>> different topologies we can support with a single kernel for ARM32 or ARM64.
>>
>> Every CPU has its own driver, so every single CPU can specify in the DT the
>> idle states.
>>
>> This simple approach allows to support the future dynamIQ system, current SMP
>> and HMP.
>>
>> Tested on:
>>  - 96boards: Hikey 620
>>  - 96boards: Hikey 960
>>  - 96boards: dragonboard410c
>>  - Mediatek 8173
>>
>> Cc: Sudeep Holla <sudeep.holla@arm.com>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Tested-by: Leo Yan <leo.yan@linaro.org>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> 
> There seems to have been quite some discussion regarding this one and I'm not
> sure about the resolution of it.
> 
> I'd feel more comfortable with an ACK or Reviewed-by from Sudeep or Lorenzo here.


Hi Rafael,

just a gentle reminder, Sudeep acked the patch.

Thanks.

  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] ARM: cpuidle: Support asymmetric idle definition Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-06-22 14:30 +0200
  Re: [PATCH 2/2] ARM: cpuidle: Support asymmetric idle definition "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-22 16:40 +0200

csiph-web