Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1672589

Re: [PATCH] block: rbd: constify rbd_attr_group and rbd_opts_tokens

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH] block: rbd: constify rbd_attr_group and rbd_opts_tokens
Date 2017-06-22 14:30 +0200
Message-ID <tV9pg-4DF-17@gated-at.bofh.it> (permalink)
References <tV95V-4vV-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 2017-06-22 at 17:34 +0530, Arvind Yadav wrote:
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   43100	   2161	     64	  45325	   b10d	drivers/block/rbd.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   43292	   1969	     64	  45325	   b10d	drivers/block/rbd.o

If you are going to do these conversions, I still think
it'd be better to use a standard struct declaration.

From 2011, (const was also added)
http://lkml.iu.edu/hypermail/linux/kernel/1104.2/00738.html

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] block: rbd: constify rbd_attr_group and rbd_opts_tokens Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-22 14:10 +0200
  Re: [PATCH] block: rbd: constify rbd_attr_group and rbd_opts_tokens Joe Perches <joe@perches.com> - 2017-06-22 14:30 +0200

csiph-web