Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672580
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs |
| Date | 2017-06-22 14:20 +0200 |
| Message-ID | <tV9fA-4zM-19@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <tSToC-4Ym-17@gated-at.bofh.it> <tT7rz-5Uk-9@gated-at.bofh.it> <tV8Wd-4b0-1@gated-at.bofh.it> <tV8We-4b0-25@gated-at.bofh.it> <tV95U-4vV-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jun 22, 2017 at 1:58 PM, Bu Tao <butao@huawei.com> wrote:
> 在 2017/6/22 19:51, Arnd Bergmann 写道:
>> On Thu, Jun 22, 2017 at 1:44 PM, Bu Tao <butao@huawei.com> wrote:
>>> 在 2017/6/17 5:51, Arnd Bergmann 写道:
>>>> On Fri, Jun 16, 2017 at 8:51 AM, Bu Tao <butao@hisilicon.com> wrote:
>>>
>>> I do not know wheher other SoC need to use the optional properties as
>>> abover. So here the name of the optional properties has "hi3660".
>>
>>
>> They should not have "hi3660" in their names either way, independent
>> of where they are used.
>
>
> Oh, change the "hi3660" to "hisilicon"?
> e.g. ufs-hi3660-use-rate-B --> ufs-hisilicon-use-rate-B
No, just 'use-rate-B', no prefix for this.
>>>> (note: this is different from the value of the "compatible" property
>>>> that
>>>> is meant to be as specific as possible".
>>>>
>>>> Also, please clarify how your binding relates to the ufshcd binding
>>>> in Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt: does
>>>> hi3660 implement any registers that are shared with ufshcd, or does
>>>> it use the same physical interface with a different register set?
>>>
>>>
>>> No, only show how to use the dt-binding for hi3660 SoC
>>
>>
>> My question was about the hardware: does hi3660 implement ufshcd
>> or not?
>
>
> YES
Ok, then the properties should be documented as optional in the
Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt file for anything
that has a proper interpretation in the context of the generic ufshcd
driver.
Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs Bu Tao <butao@huawei.com> - 2017-06-22 14:00 +0200
Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs Arnd Bergmann <arnd@arndb.de> - 2017-06-22 14:00 +0200
Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs Bu Tao <butao@huawei.com> - 2017-06-22 14:10 +0200
Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs Arnd Bergmann <arnd@arndb.de> - 2017-06-22 14:20 +0200
Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs Bu Tao <butao@huawei.com> - 2017-06-22 14:40 +0200
Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs Subhash Jadavani <subhashj@codeaurora.org> - 2017-06-23 03:10 +0200
Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs Bu Tao <butao@huawei.com> - 2017-06-23 03:20 +0200
csiph-web