Re: [PATCH] x86/microcode/AMD: make function __load_ucode_amd static

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/microcode/AMD: make function __load_ucode_amd static
Date	2017-06-22 11:20 +0200
Message-ID	<tV6rn-2G0-7@gated-at.bofh.it> (permalink)
References	<tV6rn-2G0-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 22, 2017 at 10:16:26AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The helper function __load_ucode_amd does not need to be in global
> scope, so make it static.
> 
> Cleans up sparse warning:
> "symbol '__load_ucode_amd' was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  arch/x86/kernel/cpu/microcode/amd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
> index e9f4d762aa5b..21b185793c80 100644
> --- a/arch/x86/kernel/cpu/microcode/amd.c
> +++ b/arch/x86/kernel/cpu/microcode/amd.c
> @@ -251,7 +251,7 @@ static bool get_builtin_microcode(struct cpio_data *cp, unsigned int family)
>  #endif
>  }
>  
> -void __load_ucode_amd(unsigned int cpuid_1_eax, struct cpio_data *ret)
> +static void __load_ucode_amd(unsigned int cpuid_1_eax, struct cpio_data *ret)
>  {
>  	struct ucode_cpu_info *uci;
>  	struct cpio_data cp;
> -- 

Please merge all patches making symbols static in the microcode loader,
into a single patch.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] x86/microcode/AMD: make function __load_ucode_amd static Borislav Petkov <bp@alien8.de> - 2017-06-22 11:20 +0200

csiph-web