Re: [PATCH 1/2] crypto: caam - fix gfp allocation flags (part I)

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] crypto: caam - fix gfp allocation flags (part I)
Date	2017-06-22 11:10 +0200
Message-ID	<tV6hI-2Cj-25@gated-at.bofh.it> (permalink)
References	<tThTY-4Th-5@gated-at.bofh.it> <tV6hH-2Cj-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 19, 2017 at 11:44:45AM +0300, Horia Geantă wrote:
> Changes in the SW cts (ciphertext stealing) code in
> commit 0605c41cc53ca ("crypto: cts - Convert to skcipher")
> revealed a problem in the CAAM driver:
> when cts(cbc(aes)) is executed and cts runs in SW,
> cbc(aes) is offloaded in CAAM; cts encrypts the last block
> in atomic context and CAAM incorrectly decides to use GFP_KERNEL
> for memory allocation.
> 
> Fix this by allowing GFP_KERNEL (sleeping) only when MAY_SLEEP flag is
> set, i.e. remove MAY_BACKLOG flag.
> 
> We split the fix in two parts - first is sent to -stable, while the
> second is not (since there is no known failure case).
> 
> Link: http://lkml.kernel.org/g/20170602122446.2427-1-david@sigma-star.at
> Cc: <stable@vger.kernel.org> # 4.8+
> Reported-by: David Gstir <david@sigma-star.at>
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] crypto: caam - fix gfp allocation flags (part I) Herbert Xu <herbert@gondor.apana.org.au> - 2017-06-22 11:10 +0200

csiph-web