Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1672456

Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that can migrate

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that can migrate
Date 2017-06-22 11:30 +0200
Message-ID <tV6B3-2JO-3@gated-at.bofh.it> (permalink)
References <tUTu9-26o-3@gated-at.bofh.it> <tUTu9-26o-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


* Daniel Bristot de Oliveira <bristot@redhat.com> wrote:

> Add the value of the rt_rq.rt_nr_migratory and dl_rq.dl_nr_migratory
> to the sched_debug output, for instance:
> 
> rt_rq[0]:
>   .rt_nr_running                 : 2
>   .rt_nr_migratory               : 1     <--- Like this
>   .rt_throttled                  : 0
>   .rt_time                       : 828.645877
>   .rt_runtime                    : 1000.000000
> 
> This is useful to debug problems related to the dl/rt schedulers.
> 
> This also fixes the format of some variables, that were unsigned, rather
> than signed.
> 
> [ I am sending this patch to be able to demonstrate       ]
> [ the problem in the kernel-rt, however, this patch can   ]
> [ be merged in the vanilla kernel, if people decide it    ]
> [ is worth having it.                                     ]

Note that this patch breaks in various cross-builds - here's the Alpha defconfig 
build:

/home/mingo/tip/kernel/sched/debug.c: In function 'print_rt_rq':
/home/mingo/tip/kernel/sched/debug.c:556:60: error: 'struct rt_rq' has no member 
named 'rt_nr_migratory'
  SEQ_printf(m, "  .%-30s: %lu\n", #x, (unsigned long)(rt_rq->x))
                                                            ^
/home/mingo/tip/kernel/sched/debug.c:33:17: note: in definition of macro 
'SEQ_printf'
   seq_printf(m, x);  \
...

Thanks,

	Ingo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] sched/debug: Inform the number of rt/dl task that can migrate Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-06-21 21:30 +0200
  Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that  can migrate Ingo Molnar <mingo@kernel.org> - 2017-06-22 11:30 +0200
    Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that can  migrate Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-06-22 15:10 +0200

csiph-web