Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1672434

Re: [PATCH v5 0/3] x86: stack alignment for boot code and clang

Show all headers | View raw

* Matthias Kaehlcke <mka@chromium.org> wrote:

> This series fixes an issue with the stack of the x86 boot code not
> being aligned as intended. Further it adapts the Makefile to account
> for the fact that clang uses a different option to configure the
> stack alignment than gcc (-mstack-alignment=N vs
> -mpreferred-stack-boundary=N)
> 
> Collaterally the series adds the new kbuild macro __cc-option and
> refactors the macros cc-option and hostcc-option to make use of
> __cc-option.
> 
> Matthias Kaehlcke (3):
>   kbuild: Add __cc-option macro
>   x86/build: Use __cc-option for boot code compiler options
>   x86/build: Specify stack alignment for clang
> 
>  Makefile               |  2 +-
>  arch/x86/Makefile      | 33 +++++++++++++++++++++++++--------
>  scripts/Kbuild.include | 14 ++++++++++++--
>  scripts/Makefile.host  |  6 ------
>  4 files changed, 38 insertions(+), 17 deletions(-)

So given that there are non-trivial kbuild changes here, I'd suggest these patches 
might have a better home in the kbuild tree. For the x86 bits:

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/3] x86: stack alignment for boot code and clang Matthias Kaehlcke <mka@chromium.org> - 2017-06-22 01:30 +0200
  [PATCH v5 1/3] kbuild: Add __cc-option macro Matthias Kaehlcke <mka@chromium.org> - 2017-06-22 01:30 +0200
  Re: [PATCH v5 0/3] x86: stack alignment for boot code and clang Ingo Molnar <mingo@kernel.org> - 2017-06-22 11:00 +0200
    Re: [PATCH v5 0/3] x86: stack alignment for boot code and clang Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-25 06:10 +0200

csiph-web