Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1671168

Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround
Date 2017-06-20 23:50 +0200
Message-ID <tUzc6-5At-31@gated-at.bofh.it> (permalink)
References <tUvrQ-3dH-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jun 20, 2017 at 12:48:11PM -0500, Zach Brown wrote:
> The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an
> autoneg failure case by resetting the hardware. This turns off
> intterupts. Things will work themselves out if the phy polls, as it will
> figure out it's state during a poll. However if the phy uses only
> intterupts, the phy will stall, since interrupts are off. This patch
> fixes the issue by calling config_intr after resetting the phy.
> 
> Fixes: d2fd719bcb0e ("net/phy: micrel: Add workaround for bad autoneg ")
> Signed-off-by: Zach Brown <zach.brown@ni.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround Zach Brown <zach.brown@ni.com> - 2017-06-20 19:50 +0200
  Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg  workaround Florian Fainelli <f.fainelli@gmail.com> - 2017-06-20 23:50 +0200
  Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg  workaround Andrew Lunn <andrew@lunn.ch> - 2017-06-20 23:50 +0200
  Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg  workaround David Miller <davem@davemloft.net> - 2017-06-22 17:10 +0200

csiph-web