Re: [PATCH] acer-wmi: Using zero as the first WMI instance number

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] acer-wmi: Using zero as the first WMI instance number
Date	2017-06-20 23:50 +0200
Message-ID	<tUzc6-5At-23@gated-at.bofh.it> (permalink)
References	<tUnkE-6DB-63@gated-at.bofh.it> <tUuvM-2D0-9@gated-at.bofh.it> <tUv8t-37f-1@gated-at.bofh.it> <tUyg1-4YJ-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 20, 2017 at 10:46:12PM +0200, Pali Rohár wrote:
> On Tuesday 20 June 2017 19:22:46 Andy Shevchenko wrote:
> > On Tue, Jun 20, 2017 at 7:48 PM, Pali Rohár <pali.rohar@gmail.com>
> > wrote:
> > > On Tuesday 20 June 2017 17:06:23 Lee, Chun-Yi wrote:
> > >> Pali Rohár found that there have some wmi query/evaluation
> > >> code that they used 'one' as the first WMI instance number.
> > >> But the number is indexed from zero that it's must less than
> > >> the instance_count in _WDG.
> > >> 
> > >> This patch changes those instance number from one to zero.
> > >> 
> > >> Cc: Darren Hart <dvhart@infradead.org>
> > >> Cc: Andy Shevchenko <andy@infradead.org>
> > >> Cc: Pali Rohár <pali.rohar@gmail.com>
> > >> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> > > 
> > > Looks good, Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> > 
> > Unfortunately patchwork ignores this tag.
> > So, in the future please:
> > - put a tag on a separate line
> > - do _not_ prepend it by any characters including white spaces
> > (except new line :-) )
> 
> I have not known that those lines are parsed automatically.
> Will do it in future!

:-) Thanks!

For reference, Patchwork tally's such things in the patch list view:
https://patchwork.kernel.org/project/platform-driver-x86/list/

And, selfishly, the more normalized these are, the less likely Andy and I are to
make mistakes manipulating them into the patches.

-- 
Darren Hart
VMware Open Source Technology Center

Thread

[PATCH] acer-wmi: Using zero as the first WMI instance number "Lee, Chun-Yi" <joeyli.kernel@gmail.com> - 2017-06-20 11:10 +0200
  Re: [PATCH] acer-wmi: Using zero as the first WMI instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-20 18:50 +0200
    Re: [PATCH] acer-wmi: Using zero as the first WMI instance number Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-20 19:30 +0200
      Re: [PATCH] acer-wmi: Using zero as the first WMI instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-20 22:50 +0200
        Re: [PATCH] acer-wmi: Using zero as the first WMI instance number Darren Hart <dvhart@infradead.org> - 2017-06-20 23:50 +0200
          Re: [PATCH] acer-wmi: Using zero as the first WMI instance number joeyli <jlee@suse.com> - 2017-06-21 06:40 +0200

csiph-web