Re: [patch 15/55] PCI: vmd: Create named irq domain

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [patch 15/55] PCI: vmd: Create named irq domain
Date	2017-06-20 22:10 +0200
Message-ID	<tUxDj-4LL-7@gated-at.bofh.it> (permalink)
References	<tUeKl-Xe-5@gated-at.bofh.it> <tUeU4-1fU-89@gated-at.bofh.it> <tUxtE-4rk-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 20 Jun 2017, Keith Busch wrote:
> On Tue, Jun 20, 2017 at 01:37:15AM +0200, Thomas Gleixner wrote:
> >  static int vmd_enable_domain(struct vmd_dev *vmd)
> >  {
> >  	struct pci_sysdata *sd = &vmd->sysdata;
> > +	struct fwnode_handle *fn;
> >  	struct resource *res;
> >  	u32 upper_bits;
> >  	unsigned long flags;
> > @@ -617,8 +618,13 @@ static int vmd_enable_domain(struct vmd_
> >  
> >  	sd->node = pcibus_to_node(vmd->dev->bus);
> >  
> > -	vmd->irq_domain = pci_msi_create_irq_domain(NULL, &vmd_msi_domain_info,
> > +	fn = irq_domain_alloc_named_id_fwnode("VMD-MSI", vmd->sysdata.domain);
> > +	if (!fn)
> > +		return -ENODEV;
> > +
> > +	vmd->irq_domain = pci_msi_create_irq_domain(fn, &vmd_msi_domain_info,
> >  						    x86_vector_domain);
> > +	kfree(fn);
> 
> If I'm following all this correctly, it looks like we need to use
> irq_domain_free_fwnode with irq_domain_alloc_named_id_fwnode instead of
> freeing 'fn' directly, otherwise we leak 'fwid->name'.

Yes, I'm a moron.

Thread

[patch 15/55] PCI: vmd: Create named irq domain Thomas Gleixner <tglx@linutronix.de> - 2017-06-20 02:10 +0200
  Re: [patch 15/55] PCI: vmd: Create named irq domain Keith Busch <keith.busch@intel.com> - 2017-06-20 22:00 +0200
    Re: [patch 15/55] PCI: vmd: Create named irq domain Thomas Gleixner <tglx@linutronix.de> - 2017-06-20 22:10 +0200
      Re: [patch 15/55] PCI: vmd: Create named irq domain Thomas Gleixner <tglx@linutronix.de> - 2017-06-20 22:40 +0200
  [tip:irq/core] PCI/vmd: Create named irq domain tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-06-22 19:00 +0200

csiph-web