Re: [PATCH 2/3] nohz: Move idle balancer registration to idle path

From	Rik van Riel <riel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] nohz: Move idle balancer registration to idle path
Date	2017-06-20 19:40 +0200
Message-ID	<tUvia-3ak-17@gated-at.bofh.it> (permalink)
References	<tTUsh-4VS-3@gated-at.bofh.it> <tTUsi-4VS-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, 2017-06-19 at 04:12 +0200, Frederic Weisbecker wrote:
> The idle load balancing registration path assumes that we only stop
> the
> tick when the CPU is idle, ignoring the nohz full case. As a result,
> a
> nohz full CPU that is running a task may be chosen to perform idle
> load
> balancing.
> 
> Lets make sure that only CPUs in dynticks idle mode can be picked as
> idle load balancers.

Woah. Dang.

> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>

Acked-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] nohz: Move idle balancer registration to idle path Rik van Riel <riel@redhat.com> - 2017-06-20 19:40 +0200

csiph-web