Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1670936
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/n] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi |
| Date | 2017-06-20 18:40 +0200 |
| Message-ID | <tUum6-2zG-31@gated-at.bofh.it> (permalink) |
| References | <tSH45-5q5-5@gated-at.bofh.it> <tSJ5T-6JI-5@gated-at.bofh.it> <tUbCO-7vX-15@gated-at.bofh.it> <tUrxU-Mz-33@gated-at.bofh.it> <tUtgm-1UJ-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jun 20, 2017 at 06:22:56PM +0300, Alexey Budankov wrote:
> On 20.06.2017 16:36, Mark Rutland wrote:
> >On Mon, Jun 19, 2017 at 11:31:59PM +0300, Alexey Budankov wrote:
> >>On 15.06.2017 22:56, Mark Rutland wrote:
> >>>On Thu, Jun 15, 2017 at 08:41:42PM +0300, Alexey Budankov wrote:
> >>>>+static int
> >>>>+perf_cpu_tree_iterate(struct rb_root *tree,
> >>>>+ perf_cpu_tree_callback_t callback, void *data)
> >>>>+{
> >>>>+ int ret = 0;
> >>>>+ struct rb_node *node;
> >>>>+ struct perf_event *event;
> >>>>+
> >>>>+ WARN_ON_ONCE(!tree);
> >>>>+
> >>>>+ for (node = rb_first(tree); node; node = rb_next(node)) {
> >>>>+ struct perf_event *node_event = container_of(node,
> >>>>+ struct perf_event, group_node);
> >>>>+
> >>>>+ list_for_each_entry(event, &node_event->group_list,
> >>>>+ group_list_entry) {
> >>>>+ ret = callback(event, data);
> >>>>+ if (ret)
> >>>>+ return ret;
> >>>>+ }
> >>>>+ }
> >>>>+
> >>>>+ return 0;
> >>>> }
> >>>
> >>>If you need to iterate over every event, you can use the list that
> >>>threads the whole tree.
> >>
> >>Could you please explain more on that?
> >
> >In Peter's original suggestion, we'd use a threaded tree rather than a
> >tree of lists.
> >
> >i.e. you'd have something like:
> >
> >struct threaded_rb_node {
> > struct rb_node node;
> > struct list_head head;
> >};
>
> Is this for every group leader?
Yes; *every* group leader would be directly in the threaded rb tree.
> Which objects does the head keep?
Sorry, I'm not sure how to answer that. Did the above clarify?
If not, could you rephrase the question?
Thanks,
Mark.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 1/n] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi Mark Rutland <mark.rutland@arm.com> - 2017-06-20 15:40 +0200
Re: [PATCH v3 1/n] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-06-20 17:30 +0200
Re: [PATCH v3 1/n] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi Mark Rutland <mark.rutland@arm.com> - 2017-06-20 18:40 +0200
Re: [PATCH v3 1/n] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-06-20 19:20 +0200
csiph-web