Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1670669
| From | Gerd Hoffmann <kraxel@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations |
| Date | 2017-06-20 13:00 +0200 |
| Message-ID | <tUp34-7yf-13@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <tSJIC-7cs-25@gated-at.bofh.it> <tSZDH-Ds-7@gated-at.bofh.it> <tTYvT-7uN-1@gated-at.bofh.it> <tU6jM-3YD-19@gated-at.bofh.it> <tUn1f-6h1-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2017-06-20 at 08:41 +0000, Zhang, Tina wrote:
> Hi,
>
> Thanks for all the comments. Here are the summaries:
>
> 1. Modify the structures to make it more general.
> struct vfio_device_gfx_plane_info {
> __u64 start;
> __u64 drm_format_mod;
> __u32 drm_format;
> __u32 width;
> __u32 height;
> __u32 stride;
> __u32 size;
> __u32 x_pos;
> __u32 y_pos;
> __u32 generation;
> };
Looks good to me.
> struct vfio_device_query_gfx_plane {
> __u32 argsz;
> __u32 flags;
> #define VFIO_GFX_PLANE_FLAGS_REGION_ID (1 << 0)
> #define VFIO_GFX_PLANE_FLAGS_PLANE_ID (1 << 1)
> struct vfio_device_gfx_plane_info plane_info;
> __u32 id;
> };
I'm not convinced the flags are a great idea. Whenever dmabufs or a
region is used is a static property of the device, not of each
individual plane.
I think we should have this for userspace to figure:
enum vfio_device_gfx_type {
VFIO_DEVICE_GFX_NONE,
VFIO_DEVICE_GFX_DMABUF,
VFIO_DEVICE_GFX_REGION,
};
struct vfio_device_gfx_query_caps {
__u32 argsz;
__u32 flags;
enum vfio_device_gfx_type;
};
Then this to query the plane:
struct vfio_device_gfx_query_plane {
__u32 argsz;
__u32 flags;
struct vfio_device_gfx_plane_info plane_info; /* out */
__u32 plane_type; /* in */
};
2. Remove dmabuf mgr fd and add these two ioctl commands to the vfio
device fd.
> VFIO_DEVICE_QUERY_GFX_PLANE : used to query
> vfio_device_gfx_plane_info.
Yes.
> VFIO_DEVICE_GET_DMABUF_FD: used to create and return the dmabuf fd.
Yes. The plane might have changed between query-plane and get-dmabuf
ioctl calls though, we must make sure we handle that somehow. Current
patches return plane_info on get-dmabuf ioctl too, so userspace can see
what it actually got.
With the generation we can also do something different: Pass in
plane_type and generation, and have VFIO_DEVICE_GET_DMABUF_FD return
an error in case the generation doesn't match. In that case it doesn't
make much sense any more to have a separate plane_info struct, which
was added so we don't have to duplicate things in query-plane and get-
dmabuf ioctl structs.
cheers,
Gerd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
RE: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations "Zhang, Tina" <tina.zhang@intel.com> - 2017-06-20 10:50 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-20 13:00 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Alex Williamson <alex.williamson@redhat.com> - 2017-06-20 17:10 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Kirti Wankhede <kwankhede@nvidia.com> - 2017-06-20 19:10 +0200
RE: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations "Zhang, Tina" <tina.zhang@intel.com> - 2017-06-21 01:10 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Alex Williamson <alex.williamson@redhat.com> - 2017-06-21 01:30 +0200
RE: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations "Zhang, Tina" <tina.zhang@intel.com> - 2017-06-21 11:30 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-21 13:10 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Alex Williamson <alex.williamson@redhat.com> - 2017-06-21 21:00 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-22 10:40 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Alex Williamson <alex.williamson@redhat.com> - 2017-06-22 21:00 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-23 09:30 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Zhi Wang <zhi.a.wang@intel.com> - 2017-06-23 10:10 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-23 10:40 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Alex Williamson <alex.williamson@redhat.com> - 2017-06-23 18:50 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Alex Williamson <alex.williamson@redhat.com> - 2017-06-23 19:20 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-26 08:20 +0200
RE: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations "Zhang, Tina" <tina.zhang@intel.com> - 2017-06-22 02:30 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-21 09:40 +0200
RE: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations "Zhang, Tina" <tina.zhang@intel.com> - 2017-06-24 00:00 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-26 08:40 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Alex Williamson <alex.williamson@redhat.com> - 2017-06-26 19:30 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-27 08:20 +0200
RE: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations "Zhang, Tina" <tina.zhang@intel.com> - 2017-06-28 14:50 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-29 08:50 +0200
Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Daniel Vetter <daniel@ffwll.ch> - 2017-06-29 10:40 +0200
csiph-web